From: Christoph Hellwig <hch@lst.de>
To: Mike Christie <michael.christie@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
snitzer@kernel.org, axboe@kernel.dk, martin.petersen@oracle.com,
james.bottomley@hansenpartnership.com,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 0/8] Use block pr_ops in LIO
Date: Mon, 20 Jun 2022 09:12:29 +0200 [thread overview]
Message-ID: <20220620071229.GB11418@lst.de> (raw)
In-Reply-To: <2634b3ae-f63d-c711-36cd-bf8f56ecc43b@oracle.com>
On Fri, Jun 03, 2022 at 12:55:33PM -0500, Mike Christie wrote:
> However, for nvme and for the interface we want to provide to userspace,
> do we want to implement an interface like READ_FULL_STATUS and report
> reservations where we report the host/controller/port info? If so, below
> is a patch I started.
If we wire the ops up to the nvme target we'd need that. But for now
I think the more useful case would be to use nvme as the underlying
devices for the scsi target that already has all the PR infrastructure
and helps to validate the interface.
> Notes:
> 1. I hit some issues with SCSI targets not reporting the IDs sometimes or
> sometimes they report it incorrectly. For nvme, it seems easier. SCSI has
> to handle a hand full of ways to report the ID where nvme has 2 ways to
> do the host ID.
Yeah.
> 2. I couldn't find a nvme device to test. Qemu and nvmet don't seem to
> support reservations.
Basically any dual ported PCIe SSD should support them, typically those
are the U.2 format factor ones found in servers or enclosures.
next prev parent reply other threads:[~2022-06-20 7:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 6:55 [PATCH 0/8] Use block pr_ops in LIO Mike Christie
2022-06-03 6:55 ` [PATCH 01/11] scsi: target: Rename sbc_ops to exec_cmd_ops Mike Christie
2022-06-20 7:12 ` Christoph Hellwig
2022-06-03 6:55 ` [PATCH 02/11] scsi: Rename sd_pr_command Mike Christie
2022-06-20 7:13 ` Christoph Hellwig
2022-06-03 6:55 ` [PATCH 03/11] scsi: Move sd_pr_type to header to share Mike Christie
2022-06-05 3:58 ` Bart Van Assche
2022-06-20 7:13 ` Christoph Hellwig
2022-06-03 6:55 ` [PATCH 04/11] block: Add PR callouts for read keys and reservation Mike Christie
2022-06-20 7:14 ` Christoph Hellwig
2022-06-03 6:55 ` [PATCH 05/11] scsi: Add support for block PR read keys/reservation Mike Christie
2022-06-03 6:55 ` [PATCH 06/11] dm: " Mike Christie
2022-06-03 6:55 ` [PATCH 07/11] scsi: target: Allow backends to hook into PR handling Mike Christie
2022-06-20 7:15 ` Christoph Hellwig
2022-06-03 6:55 ` [PATCH 08/11] scsi: target: Add block PR support to iblock Mike Christie
2022-06-20 7:18 ` Christoph Hellwig
2022-06-03 6:55 ` [PATCH 09/11] block, nvme: Add error for reservation conflicts Mike Christie
2022-06-03 19:45 ` Keith Busch
2022-06-03 23:08 ` Mike Christie
2022-06-04 7:38 ` Hannes Reinecke
2022-06-04 17:13 ` michael.christie
2022-06-05 9:42 ` Hannes Reinecke
2022-06-20 7:23 ` Christoph Hellwig
2022-06-05 4:00 ` [dm-devel] " Bart Van Assche
2022-06-03 6:55 ` [PATCH 10/11] scsi: Use BLK_STS_RSV_CONFLICT " Mike Christie
2022-06-03 6:55 ` [PATCH 11/11] scsi: target: Handle BLK_STS_RSV_CONFLICT Mike Christie
2022-06-03 11:46 ` [PATCH 0/8] Use block pr_ops in LIO Christoph Hellwig
2022-06-03 17:55 ` Mike Christie
2022-06-20 7:12 ` Christoph Hellwig [this message]
2022-06-05 4:01 ` [dm-devel] " Bart Van Assche
2022-06-05 16:55 ` Mike Christie
2022-06-05 18:15 ` Bart Van Assche
2022-06-06 16:38 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220620071229.GB11418@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=snitzer@kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox