Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support

Asutosh Das (asd)
2022-07-28T19:15:28Z

Hello John,

On 7/28/2022 12:10 PM, John Garry wrote:
> On 19/07/2022 08:01, Can Guo wrote:
>> +
>> +    hba->nr_queues[HCTX_TYPE_DEFAULT] = num_possible_cpus();
>> +    hba->nr_queues[HCTX_TYPE_READ] = 0;
>> +    hba->nr_queues[HCTX_TYPE_POLL] = 1;
>> +
>> +    for (i = 0; i < HCTX_MAX_TYPES; i++)
>> +        host->nr_hw_queues += hba->nr_queues[i];
>> +
>> +    host->can_queue = hba->nutrs;
>> +    host->cmd_per_lun = hba->nutrs;
>> +
>> +    /* One more reserved for dev_cmd_queue */
>> +    hba->nr_hw_queues = host->nr_hw_queues + 1;
>> +
>
> So this would mean that the host can accept .can_queue * .nr_hw_queues
> numbers of requests simultaneously - is that true?
>
That would mean that .can_queue * .nr_hw_queues numbers of request may
be queued to the host.
Please can you elaborate if you see an issue.

> thanks,
> John

-asd