Re: [PATCH 0/2] UFS Multi-Circular Queue (MCQ)

Bean Huo
2022-07-28T22:23:24Z

On Tue, 2022-07-19 at 00:01 -0700, Can Guo wrote:
> UFS Multi-Circular Queue (MCQ) has been added in UFSHCI v4.0 to
> improve storage performance.
> This patch series is a RFC implementation of this.
>

Hi Can/Asutosh,

we could remove RFC, add more detail about MCQ configuration and its
implementation. Review will takes longer since we don't have a platform
to verify it, and now only reply you to verify.

Kind regards,
Bean

> This is the initial driver implementation and it has been verified by
> booting on an emulation
> platform. During testing, all low power modes were disabled and it
> was in HS-G1 mode.
>
> Please take a look and let us know your thoughts.
>
> Asutosh Das (1):
>   scsi: ufs: Add Multi-Circular Queue support
>
> Can Guo (1):
>   scsi: ufs-qcom: Implement three CMQ related vops
>
>  drivers/ufs/core/Makefile   |   2 +-
>  drivers/ufs/core/ufs-mcq.c  | 555
> ++++++++++++++++++++++++++++++++++++++++++++
>  drivers/ufs/core/ufshcd.c   | 362 ++++++++++++++++++++---------
>  drivers/ufs/host/ufs-qcom.c | 116 +++++++++
>  drivers/ufs/host/ufs-qcom.h |   2 +
>  include/ufs/ufs.h           |   1 +
>  include/ufs/ufshcd.h        | 231 +++++++++++++++++-
>  include/ufs/ufshci.h        |  89 +++++++
>  8 files changed, 1251 insertions(+), 107 deletions(-)
>  create mode 100644 drivers/ufs/core/ufs-mcq.c
>