Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support

Bart Van Assche
2022-07-19T23:07:23Z

On 7/19/22 00:01, Can Guo wrote:
> Adds MCQ support to UFS driver.

The description of this patch is too short. It should be explained how
the UFSHCI queues are made visible to the block layer. It should also be
explained which roles are assigned to queues and how (HCTX_TYPE_*). How
the MAXQ configuration register is handled should also be explained.

The host lock is obtained in multiple UFSHCI 3.0 code paths. Information
about the role of the host lock in MCQ code should be provided.

Thanks,

Bart.