Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support

Asutosh Das (asd)
2022-07-20T17:36:51Z

Hi Bart,

On 7/19/2022 4:07 PM, Bart Van Assche wrote:
> On 7/19/22 00:01, Can Guo wrote:
>> Adds MCQ support to UFS driver.
>
> The description of this patch is too short. It should be explained how
> the UFSHCI queues are made visible to the block layer. It should also be
> explained which roles are assigned to queues and how (HCTX_TYPE_*). How
> the MAXQ configuration register is handled should also be explained.
>
> The host lock is obtained in multiple UFSHCI 3.0 code paths. Information
> about the role of the host lock in MCQ code should be provided.
>
> Thanks,
>
> Bart.
Thanks for having taken a look.
I'll check the comments and upload a next version.

-asd