From: kernel test robot <lkp@intel.com>
To: Chetan C R <quic_cchinnad@quicinc.com>, jejb@linux.ibm.com
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org,
Chetan C R <quic_cchinnad@quicinc.com>
Subject: Re: [PATCH V1] scsi: ufs: Get boot device storage type from command line
Date: Wed, 27 Jul 2022 21:04:17 +0800 [thread overview]
Message-ID: <202207272021.6YK4F8UV-lkp@intel.com> (raw)
In-Reply-To: <1658910535-31802-1-git-send-email-quic_cchinnad@quicinc.com>
Hi Chetan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on jejb-scsi/for-next]
[also build test WARNING on mkp-scsi/for-next linus/master v5.19-rc8 next-20220726]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Chetan-C-R/scsi-ufs-Get-boot-device-storage-type-from-command-line/20220727-163016
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220727/202207272021.6YK4F8UV-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/42a08523b91855ba31b0974a32f02c43b163c571
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Chetan-C-R/scsi-ufs-Get-boot-device-storage-type-from-command-line/20220727-163016
git checkout 42a08523b91855ba31b0974a32f02c43b163c571
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/ufs/host/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/ufs/host/ufs-cmdline.c:19:13: warning: no previous prototype for 'get_storage_boot_device' [-Wmissing-prototypes]
19 | const char *get_storage_boot_device(void)
| ^~~~~~~~~~~~~~~~~~~~~~~
vim +/get_storage_boot_device +19 drivers/ufs/host/ufs-cmdline.c
18
> 19 const char *get_storage_boot_device(void)
20 {
21 if (android_boot_dev_v4 && strlen(android_boot_dev_v4))
22 return android_boot_dev_v4;
23
24 else if (strlen(android_boot_dev_v3))
25 return android_boot_dev_v3;
26
27 pr_err("Not able to get Bootconfig or Kernel command line param\n");
28 return NULL;
29 };
30 EXPORT_SYMBOL_GPL(get_storage_boot_device);
31
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-07-27 13:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 8:28 [PATCH V1] scsi: ufs: Get boot device storage type from command line Chetan C R
2022-07-27 13:04 ` kernel test robot [this message]
2022-07-27 17:46 ` Bart Van Assche
2022-07-28 8:35 ` Chetan Chinnadagudihundi Ravindranath (Consultant) (QUIC)
2022-07-28 13:33 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202207272021.6YK4F8UV-lkp@intel.com \
--to=lkp@intel.com \
--cc=jejb@linux.ibm.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=quic_cchinnad@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox