From: kernel test robot <lkp@intel.com>
To: Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
linux-scsi@vger.kernel.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
martin.petersen@oracle.com,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Subject: Re: [PATCH 11/15] mpi3mr: Add SAS SATA end devices to STL
Date: Sat, 30 Jul 2022 01:32:55 +0800 [thread overview]
Message-ID: <202207300127.y29B3Vbe-lkp@intel.com> (raw)
In-Reply-To: <20220729131627.15019-12-sreekanth.reddy@broadcom.com>
Hi Sreekanth,
I love your patch! Perhaps something to improve:
[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on next-20220728]
[cannot apply to jejb-scsi/for-next linus/master v5.19-rc8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sreekanth-Reddy/mpi3mr-Added-Support-for-SAS-Transport/20220729-210902
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: i386-randconfig-a013 (https://download.01.org/0day-ci/archive/20220730/202207300127.y29B3Vbe-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 8dfaecc4c24494337933aff9d9166486ca0949f1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/e4b268bf60cc339de06db43ad3da7450cf59e9c2
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Sreekanth-Reddy/mpi3mr-Added-Support-for-SAS-Transport/20220729-210902
git checkout e4b268bf60cc339de06db43ad3da7450cf59e9c2
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/scsi/mpi3mr/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/scsi/mpi3mr/mpi3mr_os.c:1573:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
default:
^
drivers/scsi/mpi3mr/mpi3mr_os.c:1573:3: note: insert 'break;' to avoid fall-through
default:
^
break;
1 warning generated.
vim +1573 drivers/scsi/mpi3mr/mpi3mr_os.c
9fc4abfe5a5fc9f Kashyap Desai 2021-05-20 1491
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1492 /**
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1493 * mpi3mr_sastopochg_evt_bh - SASTopologyChange evt bottomhalf
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1494 * @mrioc: Adapter instance reference
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1495 * @fwevt: Firmware event reference
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1496 *
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1497 * Prints information about the SAS topology change event and
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1498 * for "not responding" event code, removes the device from the
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1499 * upper layers.
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1500 *
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1501 * Return: Nothing.
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1502 */
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1503 static void mpi3mr_sastopochg_evt_bh(struct mpi3mr_ioc *mrioc,
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1504 struct mpi3mr_fwevt *fwevt)
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1505 {
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1506 struct mpi3_event_data_sas_topology_change_list *event_data =
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1507 (struct mpi3_event_data_sas_topology_change_list *)fwevt->event_data;
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1508 int i;
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1509 u16 handle;
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1510 u8 reason_code;
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1511 u64 exp_sas_address = 0, parent_sas_address = 0;
eaf398d9cf51b23 Sreekanth Reddy 2022-07-29 1512 struct mpi3mr_hba_port *hba_port = NULL;
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1513 struct mpi3mr_tgt_dev *tgtdev = NULL;
eaf398d9cf51b23 Sreekanth Reddy 2022-07-29 1514 struct mpi3mr_sas_node *sas_expander = NULL;
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1515 unsigned long flags;
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1516 u8 link_rate, prev_link_rate, parent_phy_number;
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1517
9fc4abfe5a5fc9f Kashyap Desai 2021-05-20 1518 mpi3mr_sastopochg_evt_debug(mrioc, event_data);
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1519 if (mrioc->sas_transport_enabled) {
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1520 hba_port = mpi3mr_get_hba_port_by_id(mrioc,
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1521 event_data->io_unit_port);
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1522 if (le16_to_cpu(event_data->expander_dev_handle)) {
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1523 spin_lock_irqsave(&mrioc->sas_node_lock, flags);
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1524 sas_expander = __mpi3mr_expander_find_by_handle(mrioc,
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1525 le16_to_cpu(event_data->expander_dev_handle));
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1526 if (sas_expander) {
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1527 exp_sas_address = sas_expander->sas_address;
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1528 hba_port = sas_expander->hba_port;
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1529 }
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1530 spin_unlock_irqrestore(&mrioc->sas_node_lock, flags);
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1531 parent_sas_address = exp_sas_address;
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1532 } else
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1533 parent_sas_address = mrioc->sas_hba.sas_address;
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1534 }
9fc4abfe5a5fc9f Kashyap Desai 2021-05-20 1535
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1536 for (i = 0; i < event_data->num_entries; i++) {
580e6742205efe6 Sreekanth Reddy 2022-02-10 1537 if (fwevt->discard)
580e6742205efe6 Sreekanth Reddy 2022-02-10 1538 return;
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1539 handle = le16_to_cpu(event_data->phy_entry[i].attached_dev_handle);
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1540 if (!handle)
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1541 continue;
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1542 tgtdev = mpi3mr_get_tgtdev_by_handle(mrioc, handle);
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1543 if (!tgtdev)
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1544 continue;
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1545
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1546 reason_code = event_data->phy_entry[i].status &
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1547 MPI3_EVENT_SAS_TOPO_PHY_RC_MASK;
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1548
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1549 switch (reason_code) {
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1550 case MPI3_EVENT_SAS_TOPO_PHY_RC_TARG_NOT_RESPONDING:
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1551 if (tgtdev->host_exposed)
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1552 mpi3mr_remove_tgtdev_from_host(mrioc, tgtdev);
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1553 mpi3mr_tgtdev_del_from_list(mrioc, tgtdev);
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1554 mpi3mr_tgtdev_put(tgtdev);
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1555 break;
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1556 case MPI3_EVENT_SAS_TOPO_PHY_RC_RESPONDING:
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1557 case MPI3_EVENT_SAS_TOPO_PHY_RC_PHY_CHANGED:
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1558 case MPI3_EVENT_SAS_TOPO_PHY_RC_NO_CHANGE:
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1559 {
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1560 if (!mrioc->sas_transport_enabled || tgtdev->non_stl
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1561 || tgtdev->is_hidden)
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1562 break;
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1563 link_rate = event_data->phy_entry[i].link_rate >> 4;
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1564 prev_link_rate = event_data->phy_entry[i].link_rate & 0xF;
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1565 if (link_rate == prev_link_rate)
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1566 break;
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1567 if (!parent_sas_address)
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1568 break;
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1569 parent_phy_number = event_data->start_phy_num + i;
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1570 mpi3mr_update_links(mrioc, parent_sas_address, handle,
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1571 parent_phy_number, link_rate, hba_port);
e4b268bf60cc339 Sreekanth Reddy 2022-07-29 1572 }
13ef29ea4aa0655 Kashyap Desai 2021-05-20 @1573 default:
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1574 break;
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1575 }
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1576 if (tgtdev)
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1577 mpi3mr_tgtdev_put(tgtdev);
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1578 }
eaf398d9cf51b23 Sreekanth Reddy 2022-07-29 1579
eaf398d9cf51b23 Sreekanth Reddy 2022-07-29 1580 if (mrioc->sas_transport_enabled && (event_data->exp_status ==
eaf398d9cf51b23 Sreekanth Reddy 2022-07-29 1581 MPI3_EVENT_SAS_TOPO_ES_NOT_RESPONDING)) {
eaf398d9cf51b23 Sreekanth Reddy 2022-07-29 1582 if (sas_expander)
eaf398d9cf51b23 Sreekanth Reddy 2022-07-29 1583 mpi3mr_expander_remove(mrioc, exp_sas_address,
eaf398d9cf51b23 Sreekanth Reddy 2022-07-29 1584 hba_port);
eaf398d9cf51b23 Sreekanth Reddy 2022-07-29 1585 }
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1586 }
13ef29ea4aa0655 Kashyap Desai 2021-05-20 1587
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-07-29 17:33 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 13:16 [PATCH 00/15] mpi3mr: Added Support for SAS Transport Sreekanth Reddy
2022-07-29 13:16 ` [PATCH 01/15] mpi3mr: Add config and transport related debug flags Sreekanth Reddy
2022-07-29 16:59 ` Himanshu Madhani
2022-07-29 13:16 ` [PATCH 02/15] mpi3mr: Add framework to issue cnfg requests Sreekanth Reddy
2022-07-29 17:00 ` Himanshu Madhani
2022-08-01 7:40 ` Sreekanth Reddy
2022-08-01 16:37 ` Himanshu Madhani
2022-07-29 13:16 ` [PATCH 03/15] mpi3mr: Added helper functions to retrieve cnfg pages Sreekanth Reddy
2022-07-29 18:13 ` Himanshu Madhani
2022-07-29 13:16 ` [PATCH 04/15] mpi3mr: Enable Enclosure device add event Sreekanth Reddy
2022-07-29 18:33 ` Himanshu Madhani
2022-07-29 13:16 ` [PATCH 05/15] mpi3mr: Add framework to add phys to STL Sreekanth Reddy
2022-07-29 19:42 ` Himanshu Madhani
2022-08-01 7:46 ` Sreekanth Reddy
2022-07-29 13:16 ` [PATCH 06/15] mpi3mr: Add helper functions to retrieve device objects Sreekanth Reddy
2022-07-29 20:11 ` Himanshu Madhani
2022-08-01 7:48 ` Sreekanth Reddy
2022-07-29 13:16 ` [PATCH 07/15] mpi3mr: Add helper functions to manage device's port Sreekanth Reddy
2022-08-01 19:07 ` Himanshu Madhani
2022-07-29 13:16 ` [PATCH 08/15] mpi3mr: Enable STL on HBAs where multipath is disabled Sreekanth Reddy
2022-08-01 19:12 ` Himanshu Madhani
2022-07-29 13:16 ` [PATCH 09/15] mpi3mr: Add expander devices to STL Sreekanth Reddy
2022-08-01 20:50 ` Himanshu Madhani
2022-07-29 13:16 ` [PATCH 10/15] mpi3mr: Get target object based on rphy Sreekanth Reddy
2022-08-01 21:27 ` Himanshu Madhani
2022-07-29 13:16 ` [PATCH 11/15] mpi3mr: Add SAS SATA end devices to STL Sreekanth Reddy
2022-07-29 17:32 ` kernel test robot [this message]
2022-07-29 13:16 ` [PATCH 12/15] mpi3mr: Add framework to issue MPT transport cmds Sreekanth Reddy
2022-08-02 0:13 ` Himanshu Madhani
2022-07-29 13:16 ` [PATCH 13/15] mpi3mr: Support sas transport class callbacks Sreekanth Reddy
2022-08-02 18:11 ` Himanshu Madhani
2022-07-29 13:16 ` [PATCH 14/15] mpi3mr: Refresh sas ports during soft reset Sreekanth Reddy
2022-08-02 21:00 ` Himanshu Madhani
2022-07-29 13:16 ` [PATCH 15/15] mpi3mr: Block IOs while refreshing target dev objects Sreekanth Reddy
2022-08-02 21:12 ` Himanshu Madhani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202207300127.y29B3Vbe-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-scsi@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.petersen@oracle.com \
--cc=sreekanth.reddy@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox