From: Sebin Sebastian <mailmesebin00@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: mailmesebin00@gmail.com, Don Brace <don.brace@microchip.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Mike McGowen <mike.mcgowen@microchip.com>,
Kumar Meiyappan <Kumar.Meiyappan@microchip.com>,
Scott Teel <scott.teel@microchip.com>,
storagedev@microchip.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH -next] scsi: smartpqi: Overwriting previous value
Date: Mon, 1 Aug 2022 11:38:21 +0530 [thread overview]
Message-ID: <20220801060821.52386-1-mailmesebin00@gmail.com> (raw)
Fixes coverity warning 'Unused value'. Assigning value 256 in
shost->max_lun but that stored value is overwritten before it can be
used.
Fixes: 904f2bfda65e0 (Add driver support for multi-LUN devices)
Signed-off-by: Sebin Sebastian <mailmesebin00@gmail.com>
---
drivers/scsi/smartpqi/smartpqi_init.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
index 7a8c2c75acba..5a9fd52c6e7c 100644
--- a/drivers/scsi/smartpqi/smartpqi_init.c
+++ b/drivers/scsi/smartpqi/smartpqi_init.c
@@ -7405,7 +7405,6 @@ static int pqi_register_scsi(struct pqi_ctrl_info *ctrl_info)
shost->max_channel = PQI_MAX_BUS;
shost->max_cmd_len = MAX_COMMAND_SIZE;
shost->max_lun = PQI_MAX_LUNS_PER_DEVICE;
- shost->max_lun = ~0;
shost->max_id = ~0;
shost->max_sectors = ctrl_info->max_sectors;
shost->can_queue = ctrl_info->scsi_ml_can_queue;
--
2.34.1
reply other threads:[~2022-08-01 6:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220801060821.52386-1-mailmesebin00@gmail.com \
--to=mailmesebin00@gmail.com \
--cc=Kumar.Meiyappan@microchip.com \
--cc=don.brace@microchip.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mike.mcgowen@microchip.com \
--cc=scott.teel@microchip.com \
--cc=storagedev@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox