From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44F85C19F2D for ; Tue, 9 Aug 2022 08:51:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239274AbiHIIvr (ORCPT ); Tue, 9 Aug 2022 04:51:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231282AbiHIIvp (ORCPT ); Tue, 9 Aug 2022 04:51:45 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01BC138B7 for ; Tue, 9 Aug 2022 01:51:44 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 0DF9E68AA6; Tue, 9 Aug 2022 10:51:41 +0200 (CEST) Date: Tue, 9 Aug 2022 10:51:40 +0200 From: Christoph Hellwig To: Martin Wilck Cc: Christoph Hellwig , Mike Christie , "Martin K. Petersen" , linux-scsi@vger.kernel.org, Hannes Reinecke , Ming Lei , Bart Van Assche , Dave Prizer Subject: Re: [PATCH RESEND] scsi: scan: retry INQUIRY after timeout Message-ID: <20220809085140.GA17793@lst.de> References: <20220808202018.22224-1-mwilck@suse.com> <251c6042-5778-5d82-64e3-a2de5e1e2d36@oracle.com> <20220809065247.GA9663@lst.de> <3fa3ad7169546b1c7e9196474a29e96b719ebe67.camel@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3fa3ad7169546b1c7e9196474a29e96b719ebe67.camel@suse.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Tue, Aug 09, 2022 at 10:50:50AM +0200, Martin Wilck wrote: > Are you suggesting to re-invent REQ_OP_SCSI_{IN,OUT} to distinguish > SG_IO from kernel-internal passthrough? No. We just need a flag in struct scsi_cmnd that controls the retry behavior for passthrugh commands.