From: Christoph Hellwig <hch@lst.de>
To: Mike Christie <michael.christie@oracle.com>
Cc: bvanassche@acm.org, mwilck@suse.com, hch@lst.de,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
james.bottomley@hansenpartnership.com
Subject: Re: [PATCH 2/4] scsi: Add new SUBMITTED types for passthrough
Date: Thu, 11 Aug 2022 14:21:23 +0200 [thread overview]
Message-ID: <20220811122123.GB1742@lst.de> (raw)
In-Reply-To: <20220810034155.20744-3-michael.christie@oracle.com>
On Tue, Aug 09, 2022 at 10:41:53PM -0500, Mike Christie wrote:
> This adds 2 new SUBMITTED types so we know if a command was queued
> because of a scsi_execute user vs SG IO/tape/cd.
>
> In the next patch we can then handle errors differently based on what
> submitted the cmd. For scsi_execute we can let the scsi error handler
> retry like normal if the user has requested retries. And for other users
> we can fail fast for device errors like is expected by users like SG IO.
But do we really want to handle errors differently based on the
submitter, or based on what the submitter asks us to do? I.e. why
should this be based on the callchain vs the intention?
next prev parent reply other threads:[~2022-08-11 12:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 3:41 [PATCH 0/4] scsi: passthrough fixes/improvements Mike Christie
2022-08-10 3:41 ` [PATCH 1/4] scsi: Fix passthrough retry counter handling Mike Christie
2022-08-11 12:16 ` Christoph Hellwig
2022-08-10 3:41 ` [PATCH 2/4] scsi: Add new SUBMITTED types for passthrough Mike Christie
2022-08-11 12:21 ` Christoph Hellwig [this message]
2022-08-10 3:41 ` [PATCH 3/4] scsi: Internally retry scsi_execute commands Mike Christie
2022-08-10 10:46 ` Martin Wilck
2022-08-10 17:06 ` Mike Christie
2022-08-10 17:38 ` Mike Christie
2022-08-11 12:28 ` Christoph Hellwig
2022-08-11 16:19 ` Mike Christie
2022-08-11 9:56 ` Martin Wilck
2022-08-11 16:15 ` Mike Christie
2022-08-11 17:02 ` Martin Wilck
2022-08-11 18:22 ` Mike Christie
2022-08-11 12:27 ` Christoph Hellwig
2022-08-10 3:41 ` [PATCH 4/4] scsi: Handle UAs for pr_ops Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220811122123.GB1742@lst.de \
--to=hch@lst.de \
--cc=bvanassche@acm.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox