Re: [PATCH 2/6] scsi: target: core: add list of opcodes for RSOC

Mike Christie
2022-08-12T03:38:38Z

On 7/18/22 7:01 AM, Dmitry Bogdanov wrote:
> Reviewed-by: Roman Bolshakov <r.bolshakov@yadro.com>
> Signed-off-by: Dmitry Bogdanov <d.bogdanov@yadro.com>
> ---
> drivers/target/target_core_spc.c | 595 +++++++++++++++++++++++++++++++
> include/scsi/scsi_proto.h | 3 +
> 2 files changed, 598 insertions(+)
>
> diff --git a/drivers/target/target_core_spc.c b/drivers/target/target_core_spc.c
> index 4157f73977cf..506e28b14e5a 100644
> --- a/drivers/target/target_core_spc.c
> +++ b/drivers/target/target_core_spc.c

> +static struct target_opcode_descriptor tcm_opcode_xdwriteread10 = {
> + .support = SCSI_SUPPORT_FULL,
> + .opcode = XDWRITEREAD_10,
> + .cdb_size = 10,
> + .usage_bits = {XDWRITEREAD_10, 0x18, 0xff, 0xff,
> + 0xff, 0xff, SCSI_GROUP_NUMBER_MASK, 0xff,
> + 0xff, SCSI_CONTROL_MASK},
> +};
> +
> +static struct target_opcode_descriptor tcm_opcode_xdwriteread32 = {
> + .support = SCSI_SUPPORT_FULL,
> + .serv_action_valid = 1,
> + .opcode = VARIABLE_LENGTH_CMD,
> + .service_action = XDWRITEREAD_32,
> + .cdb_size = 32,
> + .usage_bits = {VARIABLE_LENGTH_CMD, SCSI_CONTROL_MASK, 0x00, 0x00,
> + 0x00, 0x00, SCSI_GROUP_NUMBER_MASK, 0x18,
> + 0x00, XDWRITEREAD_32, 0x18, 0x00,
> + 0xff, 0xff, 0xff, 0xff,
> + 0xff, 0xff, 0xff, 0xff,
> + 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00,
> + 0xff, 0xff, 0xff, 0xff},
> +};
> +

I just removed these because they didn't work. I think the patch was added to
one of Martin's tree after you made this patch.