Re: [PATCH 2/6] scsi: target: core: add list of opcodes for RSOC

Christoph Hellwig
2022-08-13T07:49:54Z

On Fri, Aug 12, 2022 at 11:03:07AM +0300, Dmitry Bogdanov wrote:
> > > + .support = SCSI_SUPPORT_FULL,
> > > + .opcode = XDWRITEREAD_10,
> > > + .cdb_size = 10,
> > > + .usage_bits = {XDWRITEREAD_10, 0x18, 0xff, 0xff,
> > > + 0xff, 0xff, SCSI_GROUP_NUMBER_MASK, 0xff,
> > > + 0xff, SCSI_CONTROL_MASK},
> > > +};

> > one of Martin's tree after you made this patch.
> Yes, I saw, Iwill remove XDWRITEREAD_* in the next revision.

What this does point out is that the way the patches are done,
we have a fundamental issue with these descriptors being potentially
out of sync with the actually supported commands. Once way to fix
this would be to add a parse callback to these dscriptors to unwind
sbc_parse_cdb. The big downside would be an extra expensive indirect
call per command, though.