public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Tuo Cao <91tuocao@gmail.com>
To: James.Bottomley@HansenPartnership.com,
	martin.petersen@oracle.com, khalid@gonehiking.org,
	willy@infradead.org, hare@suse.com
Cc: anil.gurumurthy@qlogic.com, sudarsana.kalluru@qlogic.com,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	91tuocao@gmail.com
Subject: [PATCH 1/9] scsi: 53c700: move spin_lock_irqsave to spin_lock in interrupt handler
Date: Sun, 14 Aug 2022 14:43:29 +0800	[thread overview]
Message-ID: <20220814064337.32621-2-91tuocao@gmail.com> (raw)
In-Reply-To: <20220814064337.32621-1-91tuocao@gmail.com>

it is unnecessary to call spin_lock_irqsave in a interrupt handler.

Signed-off-by: Tuo Cao <91tuocao@gmail.com>
---
 drivers/scsi/53c700.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/53c700.c b/drivers/scsi/53c700.c
index e1e4f9d10887..55dc0fb7943e 100644
--- a/drivers/scsi/53c700.c
+++ b/drivers/scsi/53c700.c
@@ -1490,7 +1490,6 @@ NCR_700_intr(int irq, void *dev_id)
 	__u8 istat;
 	__u32 resume_offset = 0;
 	__u8 pun = 0xff, lun = 0xff;
-	unsigned long flags;
 	int handled = 0;
 
 	/* Use the host lock to serialise access to the 53c700
@@ -1498,7 +1497,7 @@ NCR_700_intr(int irq, void *dev_id)
 	 * lock to enter the done routines.  When that happens, we
 	 * need to ensure that for this driver, the host lock and the
 	 * queue lock point to the same thing. */
-	spin_lock_irqsave(host->host_lock, flags);
+	spin_lock(host->host_lock);
 	if((istat = NCR_700_readb(host, ISTAT_REG))
 	      & (SCSI_INT_PENDING | DMA_INT_PENDING)) {
 		__u32 dsps;
@@ -1746,7 +1745,7 @@ NCR_700_intr(int irq, void *dev_id)
 		}
 	}
  out_unlock:
-	spin_unlock_irqrestore(host->host_lock, flags);
+	spin_unlock(host->host_lock);
 	return IRQ_RETVAL(handled);
 }
 
-- 
2.17.1


  reply	other threads:[~2022-08-14  6:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-14  6:43 [PATCH 0/9] move spin_lock_irqsave to spin_lock in interrupt handler Tuo Cao
2022-08-14  6:43 ` Tuo Cao [this message]
2022-08-14  6:43 ` [PATCH 2/9] scsi: a100u2w: " Tuo Cao
2022-08-14  6:43 ` [PATCH 3/9] scsi: a2091: " Tuo Cao
2022-08-14  6:43 ` [PATCH 4/9] scsi: a3000: " Tuo Cao
2022-08-14  6:43 ` [PATCH 5/9] scsi: BusLogic: " Tuo Cao
2022-08-14  6:43 ` [PATCH 6/9] scsi: advansys: " Tuo Cao
2022-08-14  6:43 ` [PATCH 7/9] scsi: aha1542: " Tuo Cao
2022-08-14  6:43 ` [PATCH 8/9] scsi: aha1740: " Tuo Cao
2022-08-14  6:43 ` [PATCH 9/9] scsi: bfad: " Tuo Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220814064337.32621-2-91tuocao@gmail.com \
    --to=91tuocao@gmail.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=anil.gurumurthy@qlogic.com \
    --cc=hare@suse.com \
    --cc=khalid@gonehiking.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sudarsana.kalluru@qlogic.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox