From: Tuo Cao <91tuocao@gmail.com>
To: James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, khalid@gonehiking.org,
willy@infradead.org, hare@suse.com
Cc: anil.gurumurthy@qlogic.com, sudarsana.kalluru@qlogic.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
91tuocao@gmail.com
Subject: [PATCH 7/9] scsi: aha1542: move spin_lock_irqsave to spin_lock in interrupt handler
Date: Sun, 14 Aug 2022 14:43:35 +0800 [thread overview]
Message-ID: <20220814064337.32621-8-91tuocao@gmail.com> (raw)
In-Reply-To: <20220814064337.32621-1-91tuocao@gmail.com>
it is unnecessary to call spin_lock_irqsave in a interrupt handler.
Signed-off-by: Tuo Cao <91tuocao@gmail.com>
---
drivers/scsi/aha1542.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c
index 552ca95157da..b49082bc5b54 100644
--- a/drivers/scsi/aha1542.c
+++ b/drivers/scsi/aha1542.c
@@ -281,7 +281,6 @@ static irqreturn_t aha1542_interrupt(int irq, void *dev_id)
struct aha1542_hostdata *aha1542 = shost_priv(sh);
int errstatus, mbi, mbo, mbistatus;
int number_serviced;
- unsigned long flags;
struct scsi_cmnd *tmp_cmd;
int flag;
struct mailbox *mb = aha1542->mb;
@@ -306,7 +305,7 @@ static irqreturn_t aha1542_interrupt(int irq, void *dev_id)
#endif
number_serviced = 0;
- spin_lock_irqsave(sh->host_lock, flags);
+ spin_lock(sh->host_lock);
while (1) {
flag = inb(INTRFLAGS(sh->io_port));
@@ -339,7 +338,7 @@ static irqreturn_t aha1542_interrupt(int irq, void *dev_id)
} while (mbi != aha1542->aha1542_last_mbi_used);
if (mb[mbi].status == 0) {
- spin_unlock_irqrestore(sh->host_lock, flags);
+ spin_unlock(sh->host_lock);
/* Hmm, no mail. Must have read it the last time around */
if (!number_serviced)
shost_printk(KERN_WARNING, sh, "interrupt received, but no mail.\n");
@@ -367,7 +366,7 @@ static irqreturn_t aha1542_interrupt(int irq, void *dev_id)
tmp_cmd = aha1542->int_cmds[mbo];
if (!tmp_cmd) {
- spin_unlock_irqrestore(sh->host_lock, flags);
+ spin_unlock(sh->host_lock);
shost_printk(KERN_WARNING, sh, "Unexpected interrupt\n");
shost_printk(KERN_WARNING, sh, "tarstat=%x, hastat=%x idlun=%x ccb#=%d\n", ccb[mbo].tarstat,
ccb[mbo].hastat, ccb[mbo].idlun, mbo);
--
2.17.1
next prev parent reply other threads:[~2022-08-14 6:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-14 6:43 [PATCH 0/9] move spin_lock_irqsave to spin_lock in interrupt handler Tuo Cao
2022-08-14 6:43 ` [PATCH 1/9] scsi: 53c700: " Tuo Cao
2022-08-14 6:43 ` [PATCH 2/9] scsi: a100u2w: " Tuo Cao
2022-08-14 6:43 ` [PATCH 3/9] scsi: a2091: " Tuo Cao
2022-08-14 6:43 ` [PATCH 4/9] scsi: a3000: " Tuo Cao
2022-08-14 6:43 ` [PATCH 5/9] scsi: BusLogic: " Tuo Cao
2022-08-14 6:43 ` [PATCH 6/9] scsi: advansys: " Tuo Cao
2022-08-14 6:43 ` Tuo Cao [this message]
2022-08-14 6:43 ` [PATCH 8/9] scsi: aha1740: " Tuo Cao
2022-08-14 6:43 ` [PATCH 9/9] scsi: bfad: " Tuo Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220814064337.32621-8-91tuocao@gmail.com \
--to=91tuocao@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=anil.gurumurthy@qlogic.com \
--cc=hare@suse.com \
--cc=khalid@gonehiking.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sudarsana.kalluru@qlogic.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox