* [PATCH] lpfc: Return DID_TRANSPORT_DISRUPTED instead of DID_REQUEUE
@ 2022-08-24 6:00 Hannes Reinecke
2022-08-24 14:17 ` James Smart
2022-09-01 5:12 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Hannes Reinecke @ 2022-08-24 6:00 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Christoph Hellwig, James Bottomley, linux-scsi, Hannes Reinecke
When the driver hits on an internal error condition returning
DID_REQUEUE will cause I/O to be retried on the same ITL nexus.
This will inhibit multipathing, resulting in endless retries
even if the error could have been resolved by using a different
ITL nexus.
So return DID_TRANSPORT_DISRUPTED to allow for multipath to engage
and route I/O to another ITL nexus.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/scsi/lpfc/lpfc_scsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
index 084c0f9fdc3a..938a5e435943 100644
--- a/drivers/scsi/lpfc/lpfc_scsi.c
+++ b/drivers/scsi/lpfc/lpfc_scsi.c
@@ -4272,7 +4272,7 @@ lpfc_fcp_io_cmd_wqe_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pwqeIn,
lpfc_cmd->result == IOERR_ABORT_REQUESTED ||
lpfc_cmd->result == IOERR_RPI_SUSPENDED ||
lpfc_cmd->result == IOERR_SLER_CMD_RCV_FAILURE) {
- cmd->result = DID_REQUEUE << 16;
+ cmd->result = DID_TRANSPORT_DISRUPTED << 16;
break;
}
if ((lpfc_cmd->result == IOERR_RX_DMA_FAILED ||
@@ -4562,7 +4562,7 @@ lpfc_scsi_cmd_iocb_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pIocbIn,
lpfc_cmd->result == IOERR_NO_RESOURCES ||
lpfc_cmd->result == IOERR_ABORT_REQUESTED ||
lpfc_cmd->result == IOERR_SLER_CMD_RCV_FAILURE) {
- cmd->result = DID_REQUEUE << 16;
+ cmd->result = DID_TRANSPORT_DISRUPTED << 16;
break;
}
if ((lpfc_cmd->result == IOERR_RX_DMA_FAILED ||
--
2.35.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] lpfc: Return DID_TRANSPORT_DISRUPTED instead of DID_REQUEUE
2022-08-24 6:00 [PATCH] lpfc: Return DID_TRANSPORT_DISRUPTED instead of DID_REQUEUE Hannes Reinecke
@ 2022-08-24 14:17 ` James Smart
2022-09-01 5:12 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: James Smart @ 2022-08-24 14:17 UTC (permalink / raw)
To: Hannes Reinecke, Martin K. Petersen
Cc: Christoph Hellwig, James Bottomley, linux-scsi
On 8/23/2022 11:00 PM, Hannes Reinecke wrote:
> When the driver hits on an internal error condition returning
> DID_REQUEUE will cause I/O to be retried on the same ITL nexus.
> This will inhibit multipathing, resulting in endless retries
> even if the error could have been resolved by using a different
> ITL nexus.
> So return DID_TRANSPORT_DISRUPTED to allow for multipath to engage
> and route I/O to another ITL nexus.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
> drivers/scsi/lpfc/lpfc_scsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
> index 084c0f9fdc3a..938a5e435943 100644
> --- a/drivers/scsi/lpfc/lpfc_scsi.c
> +++ b/drivers/scsi/lpfc/lpfc_scsi.c
> @@ -4272,7 +4272,7 @@ lpfc_fcp_io_cmd_wqe_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pwqeIn,
> lpfc_cmd->result == IOERR_ABORT_REQUESTED ||
> lpfc_cmd->result == IOERR_RPI_SUSPENDED ||
> lpfc_cmd->result == IOERR_SLER_CMD_RCV_FAILURE) {
> - cmd->result = DID_REQUEUE << 16;
> + cmd->result = DID_TRANSPORT_DISRUPTED << 16;
> break;
> }
> if ((lpfc_cmd->result == IOERR_RX_DMA_FAILED ||
> @@ -4562,7 +4562,7 @@ lpfc_scsi_cmd_iocb_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pIocbIn,
> lpfc_cmd->result == IOERR_NO_RESOURCES ||
> lpfc_cmd->result == IOERR_ABORT_REQUESTED ||
> lpfc_cmd->result == IOERR_SLER_CMD_RCV_FAILURE) {
> - cmd->result = DID_REQUEUE << 16;
> + cmd->result = DID_TRANSPORT_DISRUPTED << 16;
> break;
> }
> if ((lpfc_cmd->result == IOERR_RX_DMA_FAILED ||
We need to be careful about the conditions. But I think you handled it well.
Thanks
Reviewed-by: James Smart <jsmart2021@gmail.com>
-- james
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] lpfc: Return DID_TRANSPORT_DISRUPTED instead of DID_REQUEUE
2022-08-24 6:00 [PATCH] lpfc: Return DID_TRANSPORT_DISRUPTED instead of DID_REQUEUE Hannes Reinecke
2022-08-24 14:17 ` James Smart
@ 2022-09-01 5:12 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-09-01 5:12 UTC (permalink / raw)
To: Hannes Reinecke
Cc: Martin K . Petersen, Christoph Hellwig, James Bottomley,
linux-scsi
On Wed, 24 Aug 2022 08:00:33 +0200, Hannes Reinecke wrote:
> When the driver hits on an internal error condition returning
> DID_REQUEUE will cause I/O to be retried on the same ITL nexus.
> This will inhibit multipathing, resulting in endless retries
> even if the error could have been resolved by using a different
> ITL nexus.
> So return DID_TRANSPORT_DISRUPTED to allow for multipath to engage
> and route I/O to another ITL nexus.
>
> [...]
Applied to 6.0/scsi-fixes, thanks!
[1/1] lpfc: Return DID_TRANSPORT_DISRUPTED instead of DID_REQUEUE
https://git.kernel.org/mkp/scsi/c/c0a50cd389c3
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-01 5:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-24 6:00 [PATCH] lpfc: Return DID_TRANSPORT_DISRUPTED instead of DID_REQUEUE Hannes Reinecke
2022-08-24 14:17 ` James Smart
2022-09-01 5:12 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox