Re: [EXT] Re: [PATCH v3 1/1] tracing: Fix compile error in trace_array calls when TRACING is disabled

Arun Easi
2022-09-16T21:22:41Z

Since Steve is travelling, trying Ingo, who is a co-maintainer of trace
stuff.

Hi Ingo,

If you could review/approve the patch, that would be very helpful, as this
is a build breaker fix.

Please see the link below for more context:

Most recent (v3) patch posting:
https://lore.kernel.org/linux-scsi/20220907233308.4153-2-aeasi@marvell.com/

Steve suggesting to take the patch via SCSI tree:
https://lore.kernel.org/linux-scsi/20220906174140.41b46a5f@gandalf.local.home/

Regards,
-Arun

On Thu, 15 Sep 2022, 6:32pm, Martin K. Petersen wrote:

> External Email
>
> ----------------------------------------------------------------------
>
> Steven,
>
> Can you please review Arun's patch?
>
> > Fix this compilation error seen when CONFIG_TRACING is not enabled:
> >
> > drivers/scsi/qla2xxx/qla_os.c: In function 'qla_trace_init':
> > drivers/scsi/qla2xxx/qla_os.c:2854:25: error: implicit declaration of function
> > 'trace_array_get_by_name'; did you mean 'trace_array_set_clr_event'?
> > [-Werror=implicit-function-declaration]
> > 2854 | qla_trc_array = trace_array_get_by_name("qla2xxx");
> > | ^~~~~~~~~~~~~~~~~~~~~~~
> > | trace_array_set_clr_event
> >
> > drivers/scsi/qla2xxx/qla_os.c: In function 'qla_trace_uninit':
> > drivers/scsi/qla2xxx/qla_os.c:2869:9: error: implicit declaration of function
> > 'trace_array_put' [-Werror=implicit-function-declaration]
> > 2869 | trace_array_put(qla_trc_array);
> > | ^~~~~~~~~~~~~~~
> >
>
>