Re: [PATCH v1 02/16] ufs: core: Introduce Multi-circular queue capability

Asutosh Das
2022-09-26T21:34:49Z

On Sat, Sep 24 2022 at 01:14 -0700, Avri Altman wrote:
>>
>> + hba->mcq_sup = (hba->capabilities & MASK_MCQ_SUPPORT) >>
>> MCQ_SUPP_SHIFT;
>Since you are just testing for bit30, MASK_MCQ_SUPPORT is not really needed.
>Maybe just:
>hba->mcq_sup = (hba->capabilities >> MCQ_SUPP_SHIFT) & 1;
>
Thanks. Yeah, Mani suggested FIELD* macros as an option too.
Let me check that as well and address this in the next version.

-asd