Re: [PATCH v3 5/8] scsi: ufs: Use 'else' in ufshcd_set_dev_pwr_mode()

Adrian Hunter
2022-10-03T05:58:15Z

On 30/09/22 01:00, Bart Van Assche wrote:
> Convert if (ret) { ... } if (!ret) { ... } into
> if (ret) { ... } else { ... }.
>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>

Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
> drivers/ufs/core/ufshcd.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 78c980585dc3..02e73208b921 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -8798,10 +8798,9 @@ static int ufshcd_set_dev_pwr_mode(struct ufs_hba *hba,
> scsi_print_sense_hdr(sdp, NULL, &sshdr);
> ret = -EIO;
> }
> - }
> -
> - if (!ret)
> + } else {
> hba->curr_dev_pwr_mode = pwr_mode;
> + }
>
> scsi_device_put(sdp);
> hba->host->eh_noresume = 0;