From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Avri Altman <avri.altman@wdc.com>
Subject: [PATCH v7 6/8] scsi: ufs: Simplify ufshcd_set_dev_pwr_mode()
Date: Fri, 14 Oct 2022 17:24:16 -0700 [thread overview]
Message-ID: <20221015002418.30955-7-bvanassche@acm.org> (raw)
In-Reply-To: <20221015002418.30955-1-bvanassche@acm.org>
Simplify the code for incrementing the SCSI device reference count in
ufshcd_set_dev_pwr_mode(). This patch removes one scsi_device_put() call
that happens from atomic context.
Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Avri Altman <avri.altman@wdc.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/ufs/core/ufshcd.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 7256e6c43ca6..c8f0fe740005 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -8752,15 +8752,10 @@ static int ufshcd_set_dev_pwr_mode(struct ufs_hba *hba,
spin_lock_irqsave(hba->host->host_lock, flags);
sdp = hba->ufs_device_wlun;
- if (sdp) {
+ if (sdp && scsi_device_online(sdp))
ret = scsi_device_get(sdp);
- if (!ret && !scsi_device_online(sdp)) {
- ret = -ENODEV;
- scsi_device_put(sdp);
- }
- } else {
+ else
ret = -ENODEV;
- }
spin_unlock_irqrestore(hba->host->host_lock, flags);
if (ret)
next prev parent reply other threads:[~2022-10-15 0:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 0:24 [PATCH v7 0/8] Prepare for constifying SCSI host templates Bart Van Assche
2022-10-15 0:24 ` [PATCH v7 1/8] scsi: esas2r: Initialize two host template members implicitly Bart Van Assche
2022-10-15 0:24 ` [PATCH v7 2/8] scsi: esas2r: Introduce scsi_template_proc_dir() Bart Van Assche
2022-10-15 0:24 ` [PATCH v7 3/8] scsi: core: Fail host creation if creating the proc directory fails Bart Van Assche
2022-10-15 0:24 ` [PATCH v7 4/8] scsi: core: Introduce a new list for SCSI proc directory entries Bart Van Assche
2022-10-15 0:24 ` [PATCH v7 5/8] scsi: core: Rework scsi_single_lun_run() Bart Van Assche
2022-10-15 0:24 ` Bart Van Assche [this message]
2022-10-15 0:24 ` [PATCH v7 7/8] scsi: core: Remove the put_device() call from scsi_device_get() Bart Van Assche
2022-10-15 0:24 ` [PATCH v7 8/8] scsi: core: Release SCSI devices synchronously Bart Van Assche
2022-10-18 3:21 ` [PATCH v7 0/8] Prepare for constifying SCSI host templates Martin K. Petersen
2022-10-22 3:52 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221015002418.30955-7-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=adrian.hunter@intel.com \
--cc=avri.altman@wdc.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox