Hi Jiaming, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on jejb-scsi/for-next linus/master v6.1-rc3 next-20221102] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jiaming-Li/Implement-File-Based-optimization-functionality/20221102-133247 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next patch link: https://lore.kernel.org/r/20221102053058.21021-5-lijiaming3%40xiaomi.corp-partner.google.com patch subject: [RESEND PATCH 4/4] scsi:ufs:add fbo functionality reproduce: # https://github.com/intel-lab-lkp/linux/commit/6fd0febb07e82aa56d07582bf62ac1e09fa5d5ef git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jiaming-Li/Implement-File-Based-optimization-functionality/20221102-133247 git checkout 6fd0febb07e82aa56d07582bf62ac1e09fa5d5ef make menuconfig # enable CONFIG_COMPILE_TEST, CONFIG_WARN_MISSING_DOCUMENTS, CONFIG_WARN_ABI_ERRORS make htmldocs If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> Documentation/ABI/testing/sysfs-driver-ufs:1787: WARNING: Malformed table. >> Documentation/ABI/testing/sysfs-driver-ufs:1787: WARNING: Blank line required after table. >> Documentation/ABI/testing/sysfs-driver-ufs:1823: WARNING: Unexpected indentation. vim +1787 Documentation/ABI/testing/sysfs-driver-ufs 1783 1784 The file is read only. 1785 1786 What: /sys/class/scsi_device/*/device/fbo_dev_ctrl/fbo_prog_state > 1787 Date: November 2022 1788 Contact: li jiaming 1789 Description: This file shows the state of UFS file-based optimization. The 1790 current driver implementation supports 5 states: 1791 1792 == ==================================================== 1793 0h UFS FBO progress state is idle 1794 1h UFS FBO progress state is on-going 1795 2h UFS FBO progress state is complete analysis 1796 3h UFS FBO progress state is complete optimization 1797 FF UFS FBO progress state is general error 1798 == ==================================================== 1799 The file is read only. 1800 1801 What: /sys/class/scsi_device/*/device/fbo_dev_ctrl/fbo_operation_ctrl 1802 Date: November 2022 1803 Contact: li jiaming 1804 Description: This file controls the operation of UFS file-based optimization. 1805 Echo different value to this file to make device perform different funcs. 1806 The value are as follows 1807 == ============================================================== 1808 0h Device shall stop FBO analysis and FBO optimization operation 1809 1h Start FBO analysis based on the current LBA range 1810 2h Start FBO optimization based on the current LBA range 1811 == ============================================================== 1812 The file is write only. 1813 1814 What: /sys/class/scsi_device/*/device/fbo_dev_ctrl/fbo_exe_threshold 1815 Date: November 2022 1816 Contact: li jiaming 1817 Description: This file shows and sets the execute level of UFS file-based 1818 optimization. It means the device will do optimization operation for 1819 the ranges which fragment level equal or greater than this value .The 1820 value ranges from 0x0 to 0xA. 1821 1822 What: /sys/class/scsi_device/*/device/fbo_dev_ctrl/fbo_send_lba > 1823 Date: November 2022 1824 Contact: li jiaming 1825 Description: This file provides an interface for host to send LBA ranges to 1826 the device for UFS file-based optimization. First, we obtain the iNode 1827 info of the file, which can be used to find out the corresponding block 1828 address of the file, then add the offset of each partition to obtain the 1829 LBA of the file. We can send LBA info to the device as a comma separated 1830 string. Each adjacent pair represents a range:,. 1831 e.g. The LBA range of the file is 0x1234,0x3456;0x4567,0x5678 1832 echo 0x1234,0x3456,0x4567,0x5678 > fbo_send_lba 1833 1834 The file is write only. 1835 -- 0-DAY CI Kernel Test Service https://01.org/lkp