Re: [PATCH 3/3] nvme: Convert NVMe errors to PT_STS errors

Christoph Hellwig
2022-11-09T06:53:44Z

On Tue, Nov 08, 2022 at 09:11:06PM -0600, Mike Christie wrote:
> + case NVME_SC_ONCS_NOT_SUPPORTED:
> + sts = PR_STS_OP_NOT_SUPP;
> + break;
> + case NVME_SC_BAD_ATTRIBUTES:
> + case NVME_SC_INVALID_OPCODE:
> + case NVME_SC_INVALID_FIELD:
> + case NVME_SC_INVALID_NS:
> + sts = PR_STS_OP_INVALID;
> + break;

Second thoughts on these: shouldn't we just return negative Linux
errnos here?