[PATCH 5/6] lpfc: Change default lpfc_suppress_rsp mode to off

Justin Tee
2022-11-16T01:11:09Z

The suppress response feature is non-standard and causes difficulties
when troubleshooting with analyzer wiretraces.

At this time, diagnostic capabilities triumphs slight performance
enhancements provided by this feature. Thus, turn it off by default.

Signed-off-by: Justin Tee <justin.tee@broadcom.com>
---
drivers/scsi/lpfc/lpfc_attr.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
index 77e1b2911cb4..bf80b462f3a5 100644
--- a/drivers/scsi/lpfc/lpfc_attr.c
+++ b/drivers/scsi/lpfc/lpfc_attr.c
@@ -3828,13 +3828,13 @@ lpfc_vport_param_store(devloss_tmo)
static DEVICE_ATTR_RW(lpfc_devloss_tmo);

/*
- * lpfc_suppress_rsp: Enable suppress rsp feature is firmware supports it
- * lpfc_suppress_rsp = 0 Disable
- * lpfc_suppress_rsp = 1 Enable (default)
+ * lpfc_suppress_rsp: Enable suppress rsp feature if firmware supports it
+ * lpfc_suppress_rsp = 0 Disable (default)
+ * lpfc_suppress_rsp = 1 Enable
*
*/
-LPFC_ATTR_R(suppress_rsp, 1, 0, 1,
- "Enable suppress rsp feature is firmware supports it");
+LPFC_ATTR_R(suppress_rsp, 0, 0, 1,
+ "Enable suppress rsp feature if firmware supports it");

/*
* lpfc_nvmet_mrq: Specify number of RQ pairs for processing NVMET cmds
--
2.38.0