From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24766C4332F for ; Mon, 21 Nov 2022 22:57:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229991AbiKUW45 (ORCPT ); Mon, 21 Nov 2022 17:56:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231908AbiKUW4z (ORCPT ); Mon, 21 Nov 2022 17:56:55 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20B7FC72C1 for ; Mon, 21 Nov 2022 14:56:55 -0800 (PST) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2ALLkZjc018627; Mon, 21 Nov 2022 22:56:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=qcppdkim1; bh=IYAnO8QbxlBww+tJ/vWakdGZf2wNKn4qaiFtYCl3Sw4=; b=ehPtCxFGVQRdBkM73j+KRbEk47TrI19LFMFANJCIcAL69HsLq2AJhc5+hIj9yCk6YQwV VmDzVwgsgbePr+R/1d5sgIrZuREPHOXd/r3jHdG1D7330y5tmnJAtqPQCKHzwOjdT3b0 YB2Snhf/YW97KcZ2BgHjGVH/K8k+xxMRHYQDqEMl2Veb6gJIf5hb+vKyiuOFRkCSxAmv AV4SJsifOIBxuXvAGXA/PgR1O1dFOoLP1joOhec1DcFjcabrock+WDgvNu+2rDPKVYwQ 35TMiwYqWxBYkGuTTV3MuSv5mFsKfQpged013hS3gyOjJpSzyQSfiwC5//KjVgWNh4AH 1g== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3kxreanxb4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Nov 2022 22:56:41 +0000 Received: from nasanex01a.na.qualcomm.com (corens_vlan604_snip.qualcomm.com [10.53.140.1]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2ALMue3P028733 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Nov 2022 22:56:40 GMT Received: from asutoshd-linux1.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 21 Nov 2022 14:56:40 -0800 Date: Mon, 21 Nov 2022 14:56:34 -0800 From: Asutosh Das To: Powen Kao =?utf-8?B?KOmrmOS8r+aWhyk=?= CC: Bart Van Assche , Stanley Chu =?utf-8?B?KOacseWOn+mZnik=?= , "martin.petersen@oracle.com" , Peter Wang =?utf-8?B?KOeOi+S/oeWPiyk=?= , Naomi Chu =?utf-8?B?KOacseipoOeUsCk=?= , Alice Chao =?utf-8?B?KOi2meePruWdhyk=?= , , , Subject: Re: 52a518019c causes issue with Qualcomm UFSHC Message-ID: <20221121225634.GA20677@asutoshd-linux1.qualcomm.com> References: <20221115014804.GA24294@asutoshd-linux1.qualcomm.com> <20221117174634.GA12056@asutoshd-linux1.qualcomm.com> <584b6f9a-c4f9-8ecc-98d9-216923d85ddf@acm.org> <20221118191058.GA28646@asutoshd-linux1.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: AwPgryfTnbawRyP0xP-3w3N-vp70Jvoc X-Proofpoint-ORIG-GUID: AwPgryfTnbawRyP0xP-3w3N-vp70Jvoc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-21_18,2022-11-18_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015 suspectscore=0 bulkscore=0 priorityscore=1501 mlxlogscore=943 spamscore=0 phishscore=0 adultscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211210171 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Sat, Nov 19 2022 at 20:16 -0800, Powen Kao (高伯文) wrote: >Hi Asutosh, > > > >Reverting the patch doesn't sound feasible on MTK platform ☹ > > > >>>I don't think invoking a clock scaling notification during > >>>ufshcd_host_reset_and_restore() sounds right to me. > >But the point is that driver has the right to know that the clk is scaled no matter where ufshcd_scale_clks() is invoked, no? > > > >Do you mind applying this patch on qcom driver to check on host status before further operation? + Mani, linux-scsi Hello Powen Thanks for the change. I will think of something to work-around the issue. However, I would like to point out that a change that breaks an existing driver must be fixed or reverted, not the other way around. -asd