Re: [PATCH 06/15] scsi: core: Convert to scsi_execute_cmd

Christoph Hellwig
2022-11-22T06:38:41Z

On Mon, Nov 21, 2022 at 09:39:25PM -0600, Mike Christie wrote:
> + result = scsi_execute_cmd(sdev, cmd, REQ_OP_DRV_IN, buffer,
> + request_len, 30 * HZ, 3,
> + ((struct scsi_exec_args) { .sshdr = &sshdr }));

Maybe it's me, but I hate the syntax to declare structs inside argument
list. But even when we go with it, splitting it into multiple lines
would be a lot more readable:
((struct scsi_exec_args) {
.sshdr = &sshdr,
}));