From: Christoph Hellwig <hch@lst.de>
To: Mike Christie <michael.christie@oracle.com>
Cc: bvanassche@acm.org, mwilck@suse.com, hch@lst.de,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
james.bottomley@hansenpartnership.com
Subject: Re: [PATCH 06/15] scsi: core: Convert to scsi_execute_cmd
Date: Tue, 22 Nov 2022 07:38:36 +0100 [thread overview]
Message-ID: <20221122063836.GB14514@lst.de> (raw)
In-Reply-To: <20221122033934.33797-7-michael.christie@oracle.com>
On Mon, Nov 21, 2022 at 09:39:25PM -0600, Mike Christie wrote:
> + result = scsi_execute_cmd(sdev, cmd, REQ_OP_DRV_IN, buffer,
> + request_len, 30 * HZ, 3,
> + ((struct scsi_exec_args) { .sshdr = &sshdr }));
Maybe it's me, but I hate the syntax to declare structs inside argument
list. But even when we go with it, splitting it into multiple lines
would be a lot more readable:
((struct scsi_exec_args) {
.sshdr = &sshdr,
}));
next prev parent reply other threads:[~2022-11-22 6:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 3:39 [PATCH 00/15] Add struct to pass in optional args to scsi_execute Mike Christie
2022-11-22 3:39 ` [PATCH 01/15] scsi: Add struct for args to execution functions Mike Christie
2022-11-22 6:36 ` Christoph Hellwig
2022-11-22 9:16 ` John Garry
2022-11-22 15:44 ` Mike Christie
2022-11-22 3:39 ` [PATCH 02/15] scsi: libata: Convert to scsi_execute_cmd Mike Christie
2022-11-22 3:39 ` [PATCH 03/15] hwmon: drivetemp: " Mike Christie
2022-11-22 3:39 ` [PATCH 04/15] scsi: ch: " Mike Christie
2022-11-22 3:39 ` [PATCH 05/15] scsi: scsi_dh: " Mike Christie
2022-11-22 3:39 ` [PATCH 06/15] scsi: core: " Mike Christie
2022-11-22 6:38 ` Christoph Hellwig [this message]
2022-11-22 16:13 ` Mike Christie
2022-11-22 18:46 ` Bart Van Assche
2022-11-22 20:06 ` Mike Christie
2022-11-22 3:39 ` [PATCH 07/15] scsi: spi: " Mike Christie
2022-11-22 3:39 ` [PATCH 08/15] scsi: sd: " Mike Christie
2022-11-22 3:39 ` [PATCH 09/15] scsi: zbc: " Mike Christie
2022-11-22 3:39 ` [PATCH 10/15] scsi: ses: " Mike Christie
2022-11-22 3:39 ` [PATCH 11/15] scsi: sr: " Mike Christie
2022-11-22 3:39 ` [PATCH 12/15] scsi: virtio_scsi: " Mike Christie
2022-11-22 3:39 ` [PATCH 13/15] scsi: target_core_pscsi: " Mike Christie
2022-11-22 3:39 ` [PATCH 14/15] scsi: cxlflash: " Mike Christie
2022-11-22 3:39 ` [PATCH 15/15] scsi: Remove scsi_execute functions Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122063836.GB14514@lst.de \
--to=hch@lst.de \
--cc=bvanassche@acm.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox