Hi Dmitry,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on linus/master v6.1-rc7 next-20221202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Dmitry-Bogdanov/scsi-target-make-RTPI-an-TPG-identifier/20221202-201253
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link:    https://lore.kernel.org/r/20221202121139.28180-6-d.bogdanov%40yadro.com
patch subject: [PATCH v3 5/5] scsi: target: core: Add RTPI attribute for target port
config: m68k-allyesconfig
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/723c027e6e5ae5c1455eaae52815c696cc7cc38b
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Dmitry-Bogdanov/scsi-target-make-RTPI-an-TPG-identifier/20221202-201253
        git checkout 723c027e6e5ae5c1455eaae52815c696cc7cc38b
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/target/target_core_tpg.c: In function 'target_tpg_disable':
   drivers/target/target_core_tpg.c:491:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     491 |         int ret;
         |             ^~~
   drivers/target/target_core_tpg.c: At top level:
>> drivers/target/target_core_tpg.c:670:6: warning: no previous prototype for 'target_tpg_remove_lun' [-Wmissing-prototypes]
     670 | void target_tpg_remove_lun(
         |      ^~~~~~~~~~~~~~~~~~~~~


vim +/target_tpg_remove_lun +670 drivers/target/target_core_tpg.c

   669	
 > 670	void target_tpg_remove_lun(
   671		struct se_portal_group *tpg,
   672		struct se_lun *lun)
   673	{
   674		/*
   675		 * rcu_dereference_raw protected by se_lun->lun_group symlink
   676		 * reference to se_device->dev_group.
   677		 */
   678		struct se_device *dev = rcu_dereference_raw(lun->lun_se_dev);
   679	
   680		lun->lun_shutdown = true;
   681	
   682		core_clear_lun_from_tpg(lun, tpg);
   683		/*
   684		 * Wait for any active I/O references to percpu se_lun->lun_ref to
   685		 * be released.  Also, se_lun->lun_ref is now used by PR and ALUA
   686		 * logic when referencing a remote target port during ALL_TGT_PT=1
   687		 * and generating UNIT_ATTENTIONs for ALUA access state transition.
   688		 */
   689		transport_clear_lun_ref(lun);
   690	
   691		mutex_lock(&tpg->tpg_lun_mutex);
   692		if (lun->lun_se_dev) {
   693			target_detach_tg_pt_gp(lun);
   694	
   695			spin_lock(&dev->se_port_lock);
   696			list_del(&lun->lun_dev_link);
   697			dev->export_count--;
   698			rcu_assign_pointer(lun->lun_se_dev, NULL);
   699			spin_unlock(&dev->se_port_lock);
   700		}
   701		if (!(dev->se_hba->hba_flags & HBA_FLAGS_INTERNAL_USE))
   702			hlist_del_rcu(&lun->link);
   703	
   704		lun->lun_shutdown = false;
   705		mutex_unlock(&tpg->tpg_lun_mutex);
   706	
   707		percpu_ref_exit(&lun->lun_ref);
   708	}
   709	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp