From: Bjorn Andersson <andersson@kernel.org>
To: Johan Hovold <johan+linaro@kernel.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>, Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Bart Van Assche <bvanassche@acm.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: ufs: qcom: allow 'dma-coherent' property
Date: Mon, 5 Dec 2022 17:07:51 -0600 [thread overview]
Message-ID: <20221205230751.ismiwodjhsyxp5uv@builder.lan> (raw)
In-Reply-To: <20221205100837.29212-2-johan+linaro@kernel.org>
On Mon, Dec 05, 2022 at 11:08:36AM +0100, Johan Hovold wrote:
> UFS controllers may be cache coherent and must be marked as such in the
> devicetree to avoid data corruption.
>
> This is specifically needed on recent Qualcomm platforms like SC8280XP.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
But I think this should be picked up by James or Martin. Added them as
explicit recipients, but perhaps they would like you to resubmit this?
I'm picking the dts change for now.
Thanks,
Bjorn
> ---
> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> index f2d6298d926c..1f1d286749c0 100644
> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> @@ -44,6 +44,8 @@ properties:
> minItems: 8
> maxItems: 11
>
> + dma-coherent: true
> +
> interconnects:
> minItems: 2
> maxItems: 2
> --
> 2.37.4
>
next prev parent reply other threads:[~2022-12-05 23:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 10:08 [PATCH 0/2] arm64: dts: qcom: sc8280xp: fix UFS DMA coherency Johan Hovold
2022-12-05 10:08 ` [PATCH 1/2] dt-bindings: ufs: qcom: allow 'dma-coherent' property Johan Hovold
2022-12-05 11:59 ` Manivannan Sadhasivam
2022-12-05 12:07 ` Johan Hovold
2022-12-05 12:20 ` Manivannan Sadhasivam
2022-12-05 12:27 ` Johan Hovold
2022-12-05 13:00 ` Manivannan Sadhasivam
2022-12-05 13:12 ` Johan Hovold
2022-12-05 13:37 ` Manivannan Sadhasivam
2022-12-06 8:14 ` Krzysztof Kozlowski
2022-12-06 9:17 ` Manivannan Sadhasivam
2022-12-05 22:35 ` Rob Herring
2022-12-06 7:49 ` Johan Hovold
2022-12-05 22:35 ` Rob Herring
2022-12-05 23:07 ` Bjorn Andersson [this message]
2022-12-06 7:55 ` Johan Hovold
2022-12-05 10:08 ` [PATCH 2/2] arm64: dts: qcom: sc8280xp: fix UFS DMA coherency Johan Hovold
2022-12-05 11:37 ` Konrad Dybcio
2022-12-05 12:01 ` Manivannan Sadhasivam
2022-12-06 18:18 ` (subset) [PATCH 0/2] " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221205230751.ismiwodjhsyxp5uv@builder.lan \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=devicetree@vger.kernel.org \
--cc=jejb@linux.ibm.com \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox