Hi Mike,

I love your patch! Yet something to improve:

[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on jejb-scsi/for-next groeck-staging/hwmon-next linus/master v6.1-rc8 next-20221208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mike-Christie/scsi-Add-struct-for-args-to-execution-functions/20221209-141751
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link:    https://lore.kernel.org/r/20221209061325.705999-5-michael.christie%40oracle.com
patch subject: [PATCH v2 04/15] scsi: ch: Convert to scsi_execute_args
config: i386-randconfig-a002
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/97774504bf2fd8f79d06ad9377eaa4b892489555
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Mike-Christie/scsi-Add-struct-for-args-to-execution-functions/20221209-141751
        git checkout 97774504bf2fd8f79d06ad9377eaa4b892489555
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/scsi/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/scsi/ch.c:200:11: error: call to __compiletime_assert_284 declared with 'error' attribute: BUILD_BUG_ON failed: exec_args.sense && exec_args.sense_len != SCSI_SENSE_BUFFERSIZE
           result = scsi_execute_args(ch->device, cmd, op, buffer, buflength,
                    ^
   include/scsi/scsi_device.h:475:2: note: expanded from macro 'scsi_execute_args'
           BUILD_BUG_ON(args.sense &&                                      \
           ^
   include/linux/build_bug.h:50:2: note: expanded from macro 'BUILD_BUG_ON'
           BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
           ^
   include/linux/build_bug.h:39:37: note: expanded from macro 'BUILD_BUG_ON_MSG'
   #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
                                       ^
   note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
   include/linux/compiler_types.h:345:2: note: expanded from macro '_compiletime_assert'
           __compiletime_assert(condition, msg, prefix, suffix)
           ^
   include/linux/compiler_types.h:338:4: note: expanded from macro '__compiletime_assert'
                           prefix ## suffix();                             \
                           ^
   <scratch space>:191:1: note: expanded from here
   __compiletime_assert_284
   ^
   1 error generated.


vim +/error +200 drivers/scsi/ch.c

   184	
   185	static int
   186	ch_do_scsi(scsi_changer *ch, unsigned char *cmd, int cmd_len,
   187		   void *buffer, unsigned int buflength, enum req_op op)
   188	{
   189		int errno, retries = 0, timeout, result;
   190		struct scsi_sense_hdr sshdr;
   191		const struct scsi_exec_args exec_args = {
   192			.sshdr = &sshdr,
   193		};
   194	
   195		timeout = (cmd[0] == INITIALIZE_ELEMENT_STATUS)
   196			? timeout_init : timeout_move;
   197	
   198	 retry:
   199		errno = 0;
 > 200		result = scsi_execute_args(ch->device, cmd, op, buffer, buflength,
   201					   timeout * HZ, MAX_RETRIES, exec_args);
   202		if (result < 0)
   203			return result;
   204		if (scsi_sense_valid(&sshdr)) {
   205			if (debug)
   206				scsi_print_sense_hdr(ch->device, ch->name, &sshdr);
   207			errno = ch_find_errno(&sshdr);
   208	
   209			switch(sshdr.sense_key) {
   210			case UNIT_ATTENTION:
   211				ch->unit_attention = 1;
   212				if (retries++ < 3)
   213					goto retry;
   214				break;
   215			}
   216		}
   217		return errno;
   218	}
   219	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp