From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"mpi3mr-linuxdrv.pdl@broadcom.com"
<mpi3mr-linuxdrv.pdl@broadcom.com>,
Kashyap Desai <kashyap.desai@broadcom.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>
Subject: Re: [PATCH v2 1/3] scsi: mpi3mr: fix alltgt_info copy size in mpi3mr_get_all_tgt_info
Date: Tue, 10 Jan 2023 02:03:34 +0000 [thread overview]
Message-ID: <20230110020333.ynfymzfbrfwjaevm@shindev> (raw)
In-Reply-To: <20221213071751.qfxh5wjrwyiwvpat@shindev>
On Dec 13, 2022 / 07:17, Shinichiro Kawasaki wrote:
> Hello Sathya, thanks for the comment.
>
> On Dec 12, 2022 / 22:38, Sathya Prakash Veerichetty wrote:
> > On Mon, Dec 12, 2022 at 5:52 PM Shin'ichiro Kawasaki
[...]
> > > alltgt_info = kzalloc(size, GFP_KERNEL);
> > > if (!alltgt_info)
> > > return -ENOMEM;
> > > @@ -358,7 +365,7 @@ static long mpi3mr_get_all_tgt_info(struct mpi3mr_ioc *mrioc,
> > >
> > > sg_copy_from_buffer(job->request_payload.sg_list,
> > > job->request_payload.sg_cnt,
> > > - alltgt_info, job->request_payload.payload_len);
> > > + alltgt_info, size);
> > instead of size, this should be min_entry_len+sizeof(u32).
>
> Thanks for the comment. I read through mpi3mr_get_all_tgt_info() again. I still
> have three unclear points. Your comments on them will be appreciated.
I've posted v3 using min_entrylen as you suggested. Also I added two more
patches to the series, based on my understanding on the three points I had
noted. Your review will be appreciated.
--
Shin'ichiro Kawasaki
next prev parent reply other threads:[~2023-01-10 2:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 0:52 [PATCH v2 0/3] scsi: mpi3mr: fix issues found by KASAN Shin'ichiro Kawasaki
2022-12-13 0:52 ` [PATCH v2 1/3] scsi: mpi3mr: fix alltgt_info copy size in mpi3mr_get_all_tgt_info Shin'ichiro Kawasaki
2022-12-13 5:38 ` Sathya Prakash Veerichetty
2022-12-13 7:17 ` Shinichiro Kawasaki
2023-01-10 2:03 ` Shinichiro Kawasaki [this message]
2022-12-13 0:52 ` [PATCH v2 2/3] scsi: mpi3mr: use number of bits to manage bitmap sizes Shin'ichiro Kawasaki
2022-12-13 4:12 ` Damien Le Moal
2022-12-13 5:30 ` Sathya Prakash Veerichetty
2022-12-13 0:52 ` [PATCH v2 3/3] scsi: mpi3mr: fix missing mrioc->evtack_cmds initialization Shin'ichiro Kawasaki
2022-12-13 5:19 ` Sathya Prakash Veerichetty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110020333.ynfymzfbrfwjaevm@shindev \
--to=shinichiro.kawasaki@wdc.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mpi3mr-linuxdrv.pdl@broadcom.com \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox