From: Marijn Suijten <marijn.suijten@somainline.org>
To: Lux Aliaga <they@mint.lgbt>
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org,
kishon@kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com,
bvanassche@acm.org, keescook@chromium.org, tony.luck@intel.com,
gpiccoli@igalia.com, ~postmarketos/upstreaming@lists.sr.ht,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-scsi@vger.kernel.org, linux-hardening@vger.kernel.org,
phone-devel@vger.kernel.org, martin.botka@somainline.org
Subject: Re: [PATCH v6 0/6] arm64: dts: qcom: sm6125: UFS and xiaomi-laurel-sprout support
Date: Tue, 10 Jan 2023 13:03:15 +0100 [thread overview]
Message-ID: <20230110120315.53edpr334vlpaxc4@SoMainline.org> (raw)
In-Reply-To: <20230108195336.388349-1-they@mint.lgbt>
On 2023-01-08 16:53:30, Lux Aliaga wrote:
> Introduce Universal Flash Storage support on SM6125 and add support for the Xiaomi Mi A3 based on the former platform. Uses the name xiaomi-laurel-sprout instead of the official codename (laurel_sprout)
Don't forget to wrap these lines properly, same for the changelog below.
> due to naming limitations in the kernel.
I doubt it's a limitation, more like a convention.
> Changes since v5:
> - Drop "non-removable" property from ufs_mem_hc for sm6125 platform
> - Drop "status" and "autorepeat" properties from gpio-keys node for xiaomi-laurel-sprout
> - Rename "key-vol-up" node to "key-volume-up" for xiaomi-laurel-sprout
> - Drop "gpio-key,wakeup" property from key-volume-up node for xiaomi-laurel-sprout
No, you /replaced/ this deprecated property with wakeup-source, which
has the same meaning.
> - Set "linux,input-type" and "wakeup-source" properties on key-volume-up node for xiaomi-laurel-sprout
No, you /removed/ linux,input-type because its value 1 for EV_KEY is
already the default.
> - Change "key_vol_up" node name to "vol-up-n-state" and its label to "vol_up_n" in PM6125 GPIO node for xiaomi-laurel-sprout
> - Use labels instead of node names for PM6125 ADC channels in xiaomi laurel-sprout
> - Set "regulator-allow-set-load" properties on l4, l5, l10, l11, l18 and l24 regulators on xiaomi-laurel-sprout
>
> v5: https://lore.kernel.org/linux-devicetree/20221231222420.75233-2-they@mint.lgbt/
>
>
>
No need for excessive newlines here.
- Marijn
prev parent reply other threads:[~2023-01-10 12:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-08 19:53 [PATCH v6 0/6] arm64: dts: qcom: sm6125: UFS and xiaomi-laurel-sprout support Lux Aliaga
2023-01-08 19:53 ` [PATCH v6 1/6] dt-bindings: ufs: qcom: Add SM6125 compatible string Lux Aliaga
2023-01-08 19:53 ` [PATCH v6 2/6] dt-bindings: phy: Add QMP UFS PHY compatible for SM6125 Lux Aliaga
2023-01-09 12:19 ` Krzysztof Kozlowski
2023-01-13 18:21 ` Vinod Koul
2023-01-08 19:53 ` [PATCH v6 3/6] phy: qcom-qmp: Add SM6125 UFS PHY support Lux Aliaga
2023-01-13 18:21 ` Vinod Koul
2023-01-13 19:31 ` Dmitry Baryshkov
2023-02-09 14:34 ` Lux Aliaga
2023-01-08 19:53 ` [PATCH v6 4/6] arm64: dts: qcom: sm6125: Add UFS nodes Lux Aliaga
2023-01-09 12:18 ` Konrad Dybcio
2023-01-11 2:53 ` Lux Aliaga
2023-01-11 12:04 ` Konrad Dybcio
2023-01-17 20:01 ` Caleb Connolly
2023-01-08 19:53 ` [PATCH v6 5/6] dt-bindings: arm: qcom: Document xiaomi,laurel-sprout board Lux Aliaga
2023-01-08 19:53 ` [PATCH v6 6/6] arm64: dts: qcom: sm6125: Initial support for xiaomi-laurel-sprout Lux Aliaga
2023-01-09 12:21 ` Konrad Dybcio
2023-01-10 11:56 ` Marijn Suijten
2023-01-10 12:03 ` Marijn Suijten [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110120315.53edpr334vlpaxc4@SoMainline.org \
--to=marijn.suijten@somainline.org \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=devicetree@vger.kernel.org \
--cc=gpiccoli@igalia.com \
--cc=keescook@chromium.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.botka@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=they@mint.lgbt \
--cc=tony.luck@intel.com \
--cc=vkoul@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox