From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 913DEC05027 for ; Thu, 2 Feb 2023 09:02:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231855AbjBBJCn (ORCPT ); Thu, 2 Feb 2023 04:02:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231775AbjBBJCm (ORCPT ); Thu, 2 Feb 2023 04:02:42 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3465511C for ; Thu, 2 Feb 2023 01:02:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675328561; x=1706864561; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=FViG9TMpLgYk4KVWN5JEFfUr90OY4NYSxlfiA/GHQUs=; b=jDtoYrzAvNCiO+B0w1BxYuXxJQpQzoTf+8B6fhmq5rcVgEnmI1MJIT7z j+lagKmBP8TvGkmg9O8dnAoECMSwtz6UvvnOEVJDYxEYiuE6oIXPbXD/j nBR9PgZKF/ZNjjwmgOjE6pIj+qJZKsjlKDdvMYwdAc3u78k7p5S3OkDqM O72sUWm4U5634NdHXR3+6sTUKaX6WVpR6HmFXOEeIyO33qzXB0/MI/zao /tkA2r2Pla/8r3142h1JU+WlaGMoBofwYsk8BigaL5gX8y2jGHmPYW4I7 FBgQrhSBdK8hAi5KpBaoGDV4GIvGVj4O//Z62HzvwDsv8TCf58vxNhe/w Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="312043826" X-IronPort-AV: E=Sophos;i="5.97,267,1669104000"; d="scan'208";a="312043826" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2023 01:02:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="773794752" X-IronPort-AV: E=Sophos;i="5.97,267,1669104000"; d="scan'208";a="773794752" Received: from lkp-server01.sh.intel.com (HELO ffa7f14d1d0f) ([10.239.97.150]) by fmsmga002.fm.intel.com with ESMTP; 02 Feb 2023 01:02:26 -0800 Received: from kbuild by ffa7f14d1d0f with local (Exim 4.96) (envelope-from ) id 1pNVU4-0006MA-2o; Thu, 02 Feb 2023 09:02:20 +0000 Date: Thu, 2 Feb 2023 17:01:46 +0800 From: kernel test robot To: Bart Van Assche , "Martin K . Petersen" Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Jaegeuk Kim , Avri Altman , Adrian Hunter , linux-scsi@vger.kernel.org, Bart Van Assche , Asutosh Das , "James E.J. Bottomley" , Bean Huo , Stanley Chu , Jinyoung Choi Subject: Re: [PATCH 2/2] scsi: ufs: Use SYNCHRONIZE CACHE instead of FUA Message-ID: <202302021626.GfHCwXIh-lkp@intel.com> References: <20230201180637.2102556-3-bvanassche@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230201180637.2102556-3-bvanassche@acm.org> Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Hi Bart, I love your patch! Yet something to improve: [auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on jejb-scsi/for-next linus/master v6.2-rc6] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Bart-Van-Assche/scsi-core-Introduce-the-BLIST_BROKEN_FUA-flag/20230202-021019 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next patch link: https://lore.kernel.org/r/20230201180637.2102556-3-bvanassche%40acm.org patch subject: [PATCH 2/2] scsi: ufs: Use SYNCHRONIZE CACHE instead of FUA config: x86_64-randconfig-a012-20230130 (https://download.01.org/0day-ci/archive/20230202/202302021626.GfHCwXIh-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/4edde0173805f04faa8e79aab4de3e929ea4b7c0 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Bart-Van-Assche/scsi-core-Introduce-the-BLIST_BROKEN_FUA-flag/20230202-021019 git checkout 4edde0173805f04faa8e79aab4de3e929ea4b7c0 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/ufs/core/ufshcd.c:5060:22: error: use of undeclared identifier 'BLIST_BROKEN_FUA' sdev->sdev_bflags = BLIST_BROKEN_FUA; ^ drivers/ufs/core/ufshcd.c:9988:44: warning: shift count >= width of type [-Wshift-count-overflow] if (!dma_set_mask_and_coherent(hba->dev, DMA_BIT_MASK(64))) ^~~~~~~~~~~~~~~~ include/linux/dma-mapping.h:76:54: note: expanded from macro 'DMA_BIT_MASK' #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1)) ^ ~~~ 1 warning and 1 error generated. vim +/BLIST_BROKEN_FUA +5060 drivers/ufs/core/ufshcd.c 5031 5032 /** 5033 * ufshcd_slave_alloc - handle initial SCSI device configurations 5034 * @sdev: pointer to SCSI device 5035 * 5036 * Returns success 5037 */ 5038 static int ufshcd_slave_alloc(struct scsi_device *sdev) 5039 { 5040 struct ufs_hba *hba; 5041 5042 hba = shost_priv(sdev->host); 5043 5044 /* Mode sense(6) is not supported by UFS, so use Mode sense(10) */ 5045 sdev->use_10_for_ms = 1; 5046 5047 /* DBD field should be set to 1 in mode sense(10) */ 5048 sdev->set_dbd_for_ms = 1; 5049 5050 /* allow SCSI layer to restart the device in case of errors */ 5051 sdev->allow_restart = 1; 5052 5053 /* REPORT SUPPORTED OPERATION CODES is not supported */ 5054 sdev->no_report_opcodes = 1; 5055 5056 /* WRITE_SAME command is not supported */ 5057 sdev->no_write_same = 1; 5058 5059 /* Use SYNCHRONIZE CACHE instead of FUA to improve performance */ > 5060 sdev->sdev_bflags = BLIST_BROKEN_FUA; 5061 5062 ufshcd_lu_init(hba, sdev); 5063 5064 ufshcd_setup_links(hba, sdev); 5065 5066 return 0; 5067 } 5068 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests