Re: [PATCH 08/81] scsi: zfcp: Declare SCSI host template const

Benjamin Block
2023-03-06T10:58:55Z

On Mon, Mar 06, 2023 at 10:51:52AM +0000, Benjamin Block wrote:
> On Fri, Mar 03, 2023 at 04:29:50PM -0800, Bart Van Assche wrote:
> > Make it explicit that the SCSI host template is not modified.
> >
> > Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> > ---
> > drivers/s390/scsi/zfcp_scsi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/s390/scsi/zfcp_scsi.c b/drivers/s390/scsi/zfcp_scsi.c
> > index 3dbf4b21d127..b2a8cd792266 100644
> > --- a/drivers/s390/scsi/zfcp_scsi.c
> > +++ b/drivers/s390/scsi/zfcp_scsi.c
> > @@ -418,7 +418,7 @@ static int zfcp_scsi_sysfs_host_reset(struct Scsi_Host *shost, int reset_type)
> >
> > struct scsi_transport_template *zfcp_scsi_transport_template;
> >
> > -static struct scsi_host_template zfcp_scsi_host_template = {
> > +static const struct scsi_host_template zfcp_scsi_host_template = {
> > .module = THIS_MODULE,
> > .name = "zfcp",
> > .queuecommand = zfcp_scsi_queuecommand,
>
> Yup, good change IMO.
>
>
> Acked-by: Benjamin Block <bblock@de.ibm.com>
>

Oups. Sorry. That's the wrong email address.

Acked-by: Benjamin Block <bblock@linux.ibm.com>

--
Best Regards, Benjamin Block / Linux on IBM Z Kernel Development / IBM Systems
IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy
Vorsitz. AufsR.: Gregor Pillen / Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294