Re: [PATCH 04/81] ata: Declare SCSI host templates const

Damien Le Moal
2023-03-06T01:41:43Z

On 3/4/23 09:29, Bart Van Assche wrote:
> Make it explicit that ATA host templates are not modified.
>
> Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Ming Lei <ming.lei@redhat.com>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: John Garry <john.garry@huawei.com>
> Cc: Mike Christie <michael.christie@oracle.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>

Note: please cc linux-ide for ATA patches.

I cannot take this as it causes a warning without all patches.

drivers/ata/libata-scsi.c:4198:41: error: passing argument 1 of
‘scsi_host_alloc’ discards ‘const’ qualifier from pointer target type
[-Werror=discarded-qualifiers]
4198 | shost = scsi_host_alloc(sht, sizeof(struct ata_port *));
| ^~~

Martin,

Can you take this one ?

Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

--
Damien Le Moal
Western Digital Research