Re: [PATCH 02/81] scsi: core: Declare most SCSI host template pointers const

Bart Van Assche
2023-03-06T19:41:37Z

On 3/6/23 10:55, John Garry wrote:
> On 06/03/2023 16:07, Bart Van Assche wrote:
>> Another example from drivers/scsi/bnx2fc/bnx2fc_fcoe.c:
>>
>>      bnx2fc_shost_template.can_queue = hba->max_outstanding_cmds;
>
> BTW, surely we should be setting shost->can_queue =
> hba->max_outstanding_cmds after scsi_host_alloc() and not modifying
> bnx2fc_shost_template, right? The series is already huge, so this stuff
> would be done separately, I suppose.

Hi John,

If anyone else wants to work on this that's fine with me. My view is
that the SCSI core should support declaring host templates const but I'm
not sure it's worth it to make changes in old drivers such that their
SCSI host template can be declared const. One class of SCSI LLDs that
does not have a const SCSI host template are the NCR drivers. The NCR
SCSI host controller was popular 40 years ago. There are probably not
many working SCSI devices left that are based on this SCSI controller.

Bart.