From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D7F5C61DA4 for ; Mon, 6 Mar 2023 10:52:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230054AbjCFKwi (ORCPT ); Mon, 6 Mar 2023 05:52:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229539AbjCFKwg (ORCPT ); Mon, 6 Mar 2023 05:52:36 -0500 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3ABFA206A3 for ; Mon, 6 Mar 2023 02:52:15 -0800 (PST) Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32692MWh001460; Mon, 6 Mar 2023 10:51:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : sender : content-transfer-encoding : mime-version; s=pp1; bh=Nd/UMPhKfg9rk6jJ5evEgk9ZGVEVQJaaewATHwktCxA=; b=Nut95q7x2sQtxvNURlaFijMTLHdm10Jd9r7KvrJnsN/M+KcT7q0YN+EiGsVLYD9VioNi g32fpzSPQnFF+DfneJJXyOIgWGAl2jfNOdZvkEGkcavnf07kjjUeQ7k7xhGasr+W7QrW Kvj1OeRrxnn/2Fo4Sp76T+dXFCwNrUj0aXX6jTVeY/2iIEuRdPrgLRMGO4wBuXrshAaF dBVwJtyRFvjCWjdNK2mLNU+FQ1aOSsSvQY4QQCxk8I3tdkeq1yZjc/b6XFuWZTd15dMK WsMHW8AkCR0bnv+b8Voi9WLPnDve7YVnIphmWjHTzPGZIYTAg9E7upk3nE7R2AIuE8Gy 8Q== Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3p507nrs7h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Mar 2023 10:51:59 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 325JZFVP006237; Mon, 6 Mar 2023 10:51:57 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma03ams.nl.ibm.com (PPS) with ESMTPS id 3p418ctjwy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Mar 2023 10:51:57 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 326AprTH55443896 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Mar 2023 10:51:53 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B361720043; Mon, 6 Mar 2023 10:51:53 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9AC3320040; Mon, 6 Mar 2023 10:51:53 +0000 (GMT) Received: from t480-pf1aa2c2 (unknown [9.171.78.75]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 6 Mar 2023 10:51:53 +0000 (GMT) Received: from bblock by t480-pf1aa2c2 with local (Exim 4.96) (envelope-from ) id 1pZ8Rd-0009Tb-03; Mon, 06 Mar 2023 11:51:53 +0100 Date: Mon, 6 Mar 2023 10:51:52 +0000 From: Benjamin Block To: Bart Van Assche Cc: "Martin K . Petersen" , linux-scsi@vger.kernel.org, Steffen Maier , Heiko Carstens , Vasily Gorbik , Alexander Gordeev Subject: Re: [PATCH 08/81] scsi: zfcp: Declare SCSI host template const Message-ID: <20230306105152.GC8597@t480-pf1aa2c2.fritz.box> References: <20230304003103.2572793-1-bvanassche@acm.org> <20230304003103.2572793-9-bvanassche@acm.org> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20230304003103.2572793-9-bvanassche@acm.org> Sender: Benjamin Block X-TM-AS-GCONF: 00 X-Proofpoint-GUID: lFfSSIbWndkt0Miy7DF2HCAox2b_3Skh X-Proofpoint-ORIG-GUID: lFfSSIbWndkt0Miy7DF2HCAox2b_3Skh Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-06_03,2023-03-06_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 adultscore=0 phishscore=0 mlxlogscore=999 bulkscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 impostorscore=0 mlxscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303060091 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Fri, Mar 03, 2023 at 04:29:50PM -0800, Bart Van Assche wrote: > Make it explicit that the SCSI host template is not modified. > > Signed-off-by: Bart Van Assche > --- > drivers/s390/scsi/zfcp_scsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s390/scsi/zfcp_scsi.c b/drivers/s390/scsi/zfcp_scsi.c > index 3dbf4b21d127..b2a8cd792266 100644 > --- a/drivers/s390/scsi/zfcp_scsi.c > +++ b/drivers/s390/scsi/zfcp_scsi.c > @@ -418,7 +418,7 @@ static int zfcp_scsi_sysfs_host_reset(struct Scsi_Host *shost, int reset_type) > > struct scsi_transport_template *zfcp_scsi_transport_template; > > -static struct scsi_host_template zfcp_scsi_host_template = { > +static const struct scsi_host_template zfcp_scsi_host_template = { > .module = THIS_MODULE, > .name = "zfcp", > .queuecommand = zfcp_scsi_queuecommand, Yup, good change IMO. Acked-by: Benjamin Block -- Best Regards, Benjamin Block / Linux on IBM Z Kernel Development / IBM Systems IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy Vorsitz. AufsR.: Gregor Pillen / Geschäftsführung: David Faller Sitz der Gesellschaft: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294