From: Bjorn Helgaas <helgaas@kernel.org>
To: "James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
Don Brace <don.brace@microchip.com>,
storagedev@microchip.com
Subject: [PATCH 06/10] scsi: hpsa: Remove unnecessary pci_disable_pcie_error_reporting() comment
Date: Tue, 7 Mar 2023 12:28:38 -0600 [thread overview]
Message-ID: <20230307182842.870378-7-helgaas@kernel.org> (raw)
In-Reply-To: <20230307182842.870378-1-helgaas@kernel.org>
From: Bjorn Helgaas <bhelgaas@google.com>
105a3dbc7452 ("hpsa: clean up driver init") added a comment about
pci_disable_pcie_error_reporting(), but hpsa has never called either
pci_enable_pcie_error_reporting() or pci_disable_pcie_error_reporting().
Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core is responsible for managing PCIe device error
reporting.
Remove the comment about pci_disable_pcie_error_reporting().
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Don Brace <don.brace@microchip.com>
Cc: storagedev@microchip.com
---
drivers/scsi/hpsa.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index f6da34850af9..fec7e17747f7 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -9108,7 +9108,6 @@ static void hpsa_remove_one(struct pci_dev *pdev)
free_percpu(h->lockup_detected); /* init_one 2 */
h->lockup_detected = NULL; /* init_one 2 */
- /* (void) pci_disable_pcie_error_reporting(pdev); */ /* init_one 1 */
hpda_free_ctlr_info(h); /* init_one 1 */
}
--
2.25.1
next prev parent reply other threads:[~2023-03-07 18:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 18:28 [PATCH 00/10] PCI/AER: Remove redundant Device Control Error Reporting Enable Bjorn Helgaas
2023-03-07 18:28 ` [PATCH 01/10] scsi: aacraid: Drop redundant pci_enable_pcie_error_reporting() Bjorn Helgaas
2023-03-07 18:28 ` [PATCH 02/10] scsi: arcmsr: Remove unnecessary aer.h include Bjorn Helgaas
2023-03-07 18:28 ` [PATCH 03/10] scsi: be2iscsi: Drop redundant pci_enable_pcie_error_reporting() Bjorn Helgaas
2023-03-07 18:28 ` [PATCH 04/10] scsi: bfa: " Bjorn Helgaas
2023-03-07 18:28 ` [PATCH 05/10] scsi: csiostor: Remove unnecessary aer.h include Bjorn Helgaas
2023-03-07 18:28 ` Bjorn Helgaas [this message]
2023-03-07 18:28 ` [PATCH 07/10] scsi: lpfc: Drop redundant pci_enable_pcie_error_reporting() Bjorn Helgaas
2023-03-07 18:28 ` [PATCH 08/10] scsi: mpt3sas: " Bjorn Helgaas
2023-03-07 18:28 ` [PATCH 09/10] scsi: qla2xxx: " Bjorn Helgaas
2023-03-07 18:28 ` [PATCH 10/10] scsi: qla4xxx: " Bjorn Helgaas
2023-03-10 3:03 ` [PATCH 00/10] PCI/AER: Remove redundant Device Control Error Reporting Enable Martin K. Petersen
2023-03-17 4:04 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230307182842.870378-7-helgaas@kernel.org \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=don.brace@microchip.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=storagedev@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox