Re: [PATCH v2 04/82] ata: Declare SCSI host templates const

Jon Hunter
2023-03-10T15:03:33Z

On 09/03/2023 19:24, Bart Van Assche wrote:
> Make it explicit that ATA host templates are not modified.
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Ming Lei <ming.lei@redhat.com>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: John Garry <john.g.garry@oracle.com>
> Cc: Mike Christie <michael.christie@oracle.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/ata/acard-ahci.c | 2 +-
> drivers/ata/ahci.c | 2 +-
> drivers/ata/ahci.h | 2 +-
> drivers/ata/ahci_brcm.c | 2 +-
> drivers/ata/ahci_ceva.c | 2 +-
> drivers/ata/ahci_da850.c | 2 +-
> drivers/ata/ahci_dm816.c | 2 +-
> drivers/ata/ahci_dwc.c | 2 +-
> drivers/ata/ahci_imx.c | 2 +-
> drivers/ata/ahci_mtk.c | 2 +-
> drivers/ata/ahci_mvebu.c | 2 +-
> drivers/ata/ahci_platform.c | 2 +-
> drivers/ata/ahci_qoriq.c | 2 +-
> drivers/ata/ahci_seattle.c | 2 +-
> drivers/ata/ahci_st.c | 2 +-
> drivers/ata/ahci_sunxi.c | 2 +-
> drivers/ata/ahci_tegra.c | 2 +-
> drivers/ata/ahci_xgene.c | 2 +-
> drivers/ata/ata_generic.c | 2 +-
> drivers/ata/ata_piix.c | 6 +++---
> drivers/ata/libahci.c | 4 ++--
> drivers/ata/libahci_platform.c | 2 +-
> drivers/ata/libata-core.c | 4 ++--
> drivers/ata/libata-scsi.c | 2 +-
> drivers/ata/libata-sff.c | 8 ++++----
> drivers/ata/libata.h | 2 +-
> drivers/ata/pata_acpi.c | 2 +-
> drivers/ata/pata_ali.c | 2 +-
> drivers/ata/pata_amd.c | 2 +-
> drivers/ata/pata_arasan_cf.c | 2 +-
> drivers/ata/pata_artop.c | 2 +-
> drivers/ata/pata_atiixp.c | 2 +-
> drivers/ata/pata_atp867x.c | 2 +-
> drivers/ata/pata_buddha.c | 2 +-
> drivers/ata/pata_cmd640.c | 2 +-
> drivers/ata/pata_cmd64x.c | 2 +-
> drivers/ata/pata_cs5520.c | 2 +-
> drivers/ata/pata_cs5530.c | 2 +-
> drivers/ata/pata_cs5535.c | 2 +-
> drivers/ata/pata_cs5536.c | 2 +-
> drivers/ata/pata_cypress.c | 2 +-
> drivers/ata/pata_efar.c | 2 +-
> drivers/ata/pata_ep93xx.c | 2 +-
> drivers/ata/pata_falcon.c | 2 +-
> drivers/ata/pata_ftide010.c | 2 +-
> drivers/ata/pata_gayle.c | 2 +-
> drivers/ata/pata_hpt366.c | 2 +-
> drivers/ata/pata_hpt37x.c | 2 +-
> drivers/ata/pata_hpt3x2n.c | 2 +-
> drivers/ata/pata_hpt3x3.c | 2 +-
> drivers/ata/pata_icside.c | 2 +-
> drivers/ata/pata_imx.c | 2 +-
> drivers/ata/pata_isapnp.c | 2 +-
> drivers/ata/pata_it8213.c | 2 +-
> drivers/ata/pata_it821x.c | 2 +-
> drivers/ata/pata_ixp4xx_cf.c | 2 +-
> drivers/ata/pata_jmicron.c | 2 +-
> drivers/ata/pata_legacy.c | 2 +-
> drivers/ata/pata_macio.c | 2 +-
> drivers/ata/pata_marvell.c | 2 +-
> drivers/ata/pata_mpc52xx.c | 2 +-
> drivers/ata/pata_mpiix.c | 2 +-
> drivers/ata/pata_netcell.c | 2 +-
> drivers/ata/pata_ninja32.c | 2 +-
> drivers/ata/pata_ns87410.c | 2 +-
> drivers/ata/pata_ns87415.c | 2 +-
> drivers/ata/pata_octeon_cf.c | 2 +-
> drivers/ata/pata_of_platform.c | 2 +-
> drivers/ata/pata_oldpiix.c | 2 +-
> drivers/ata/pata_opti.c | 2 +-
> drivers/ata/pata_optidma.c | 2 +-
> drivers/ata/pata_parport/pata_parport.c | 2 +-
> drivers/ata/pata_pcmcia.c | 2 +-
> drivers/ata/pata_pdc2027x.c | 2 +-
> drivers/ata/pata_pdc202xx_old.c | 2 +-
> drivers/ata/pata_piccolo.c | 2 +-
> drivers/ata/pata_platform.c | 4 ++--
> drivers/ata/pata_pxa.c | 2 +-
> drivers/ata/pata_radisys.c | 2 +-
> drivers/ata/pata_rb532_cf.c | 2 +-
> drivers/ata/pata_rdc.c | 2 +-
> drivers/ata/pata_rz1000.c | 2 +-
> drivers/ata/pata_sc1200.c | 2 +-
> drivers/ata/pata_sch.c | 2 +-
> drivers/ata/pata_serverworks.c | 6 +++---
> drivers/ata/pata_sil680.c | 2 +-
> drivers/ata/pata_sis.c | 2 +-
> drivers/ata/pata_sl82c105.c | 2 +-
> drivers/ata/pata_triflex.c | 2 +-
> drivers/ata/pata_via.c | 2 +-
> drivers/ata/pdc_adma.c | 2 +-
> drivers/ata/sata_dwc_460ex.c | 2 +-
> drivers/ata/sata_fsl.c | 2 +-
> drivers/ata/sata_highbank.c | 2 +-
> drivers/ata/sata_inic162x.c | 2 +-
> drivers/ata/sata_mv.c | 4 ++--
> drivers/ata/sata_nv.c | 8 ++++----
> drivers/ata/sata_promise.c | 2 +-
> drivers/ata/sata_qstor.c | 2 +-
> drivers/ata/sata_rcar.c | 2 +-
> drivers/ata/sata_sil.c | 2 +-
> drivers/ata/sata_sil24.c | 2 +-
> drivers/ata/sata_sis.c | 2 +-
> drivers/ata/sata_svw.c | 2 +-
> drivers/ata/sata_sx4.c | 2 +-
> drivers/ata/sata_uli.c | 2 +-
> drivers/ata/sata_via.c | 2 +-
> drivers/ata/sata_vsc.c | 2 +-
> include/linux/ahci_platform.h | 2 +-
> include/linux/ata_platform.h | 2 +-
> include/linux/libata.h | 10 +++++-----
> 111 files changed, 129 insertions(+), 129 deletions(-)

...

> diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
> index 4fb94db1217d..8e5e2b359f2d 100644
> --- a/drivers/ata/ahci_tegra.c
> +++ b/drivers/ata/ahci_tegra.c
> @@ -506,7 +506,7 @@ static const struct of_device_id tegra_ahci_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, tegra_ahci_of_match);
>
> -static struct scsi_host_template ahci_platform_sht = {
> +static const struct scsi_host_template ahci_platform_sht = {
> AHCI_SHT(DRV_NAME),
> };

For Tegra ...

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

--
nvpublic