Re: [PATCH v3 79/80] scsi: ufs: Declare SCSI host template const

Bart Van Assche
2024-01-08T17:48:13Z

On 1/4/24 01:52, Peter Wang (王信友) wrote:
> On Wed, 2023-03-22 at 12:55 -0700, Bart Van Assche wrote:
>> Make it explicit that the SCSI host template is not modified.
>>
>> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
>> ---
>> drivers/ufs/core/ufshcd.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
>> index 8e7dfaadc691..35a3bd95c5e4 100644
>> --- a/drivers/ufs/core/ufshcd.c
>> +++ b/drivers/ufs/core/ufshcd.c
>> @@ -8751,7 +8751,7 @@ static struct ufs_hba_variant_params
>> ufs_hba_vps = {
>> .ondemand_data.downdifferential = 5,
>> };
>>
>> -static struct scsi_host_template ufshcd_driver_template = {
>> +static const struct scsi_host_template ufshcd_driver_template = {
>> .module = THIS_MODULE,
>> .name = UFSHCD,
>> .proc_name = UFSHCD,
>
> Hi Bart,
>
> This patch change scsi_host_templete to const.
> If mediatek host want to modify deault rpm_autosuspend_delay timer,
> could you have any suggestions?

Hi Peter,

Please add a new rpm_autosuspend_delay member to struct Scsi_Host and add code
in scsi_host_alloc() for copying that member from the host template into struct
Scsi_Host. An example is available in commit b125bb99559e.

Bart.