From: Benjamin Block <bblock@linux.ibm.com>
To: Enze Li <lienze@kylinos.cn>
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, enze.li@gmx.com
Subject: Re: [PATCH] scsi: sr: simplify the sr_open function
Date: Thu, 30 Mar 2023 14:46:30 +0000 [thread overview]
Message-ID: <20230330144630.GD10558@t480-pf1aa2c2.fritz.box> (raw)
In-Reply-To: <20230327030237.3407253-1-lienze@kylinos.cn>
On Mon, Mar 27, 2023 at 11:02:37AM +0800, Enze Li wrote:
> Simplify the sr_open function by removing the goto label as it does only
> return one error code.
>
> Signed-off-by: Enze Li <lienze@kylinos.cn>
> ---
> drivers/scsi/sr.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
Looks good to me.
Reviewed-by: Benjamin Block <bblock@linux.ibm.com>
--
Best Regards, Benjamin Block / Linux on IBM Z Kernel Development
IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy
Vors. Aufs.-R.: Gregor Pillen / Geschäftsführung: David Faller
Sitz der Ges.: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294
next prev parent reply other threads:[~2023-03-30 14:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 3:02 [PATCH] scsi: sr: simplify the sr_open function Enze Li
2023-03-29 20:50 ` Bart Van Assche
2023-03-30 14:46 ` Benjamin Block [this message]
2023-04-03 1:37 ` Martin K. Petersen
2023-04-12 2:04 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2022-09-16 9:04 Enze Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330144630.GD10558@t480-pf1aa2c2.fritz.box \
--to=bblock@linux.ibm.com \
--cc=enze.li@gmx.com \
--cc=jejb@linux.ibm.com \
--cc=lienze@kylinos.cn \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox