Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Mike Christie <michael.christie@oracle.com>
To: bvanassche@acm.org, hch@lst.de, martin.petersen@oracle.com,
	linux-scsi@vger.kernel.org,
	james.bottomley@hansenpartnership.com,
	linux-block@vger.kernel.org, dm-devel@redhat.com,
	snitzer@kernel.org, axboe@kernel.dk,
	linux-nvme@lists.infradead.org, chaitanyak@nvidia.com,
	kbusch@kernel.org, target-devel@vger.kernel.org
Cc: Mike Christie <michael.christie@oracle.com>
Subject: [PATCH v6 07/18] nvme: Fix reservation status related structs
Date: Fri,  7 Apr 2023 15:05:40 -0500	[thread overview]
Message-ID: <20230407200551.12660-8-michael.christie@oracle.com> (raw)
In-Reply-To: <20230407200551.12660-1-michael.christie@oracle.com>

This fixes the following issues with the reservation status structs:

1. resv10 is bytes 23:10 so it should be 14 bytes.
2. regctl_ds only supports 64 bit host IDs.

These are not currently used, but will be in this patchset which adds
support for the reservation report command.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
---
 include/linux/nvme.h | 38 ++++++++++++++++++++++++++++++--------
 1 file changed, 30 insertions(+), 8 deletions(-)

diff --git a/include/linux/nvme.h b/include/linux/nvme.h
index 779507ac750b..83704fc04a94 100644
--- a/include/linux/nvme.h
+++ b/include/linux/nvme.h
@@ -759,20 +759,42 @@ enum {
 	NVME_LBART_ATTRIB_HIDE	= 1 << 1,
 };
 
+struct nvme_registered_ctrl {
+	__le16	cntlid;
+	__u8	rcsts;
+	__u8	rsvd3[5];
+	__le64	hostid;
+	__le64	rkey;
+};
+
 struct nvme_reservation_status {
 	__le32	gen;
 	__u8	rtype;
 	__u8	regctl[2];
 	__u8	resv5[2];
 	__u8	ptpls;
-	__u8	resv10[13];
-	struct {
-		__le16	cntlid;
-		__u8	rcsts;
-		__u8	resv3[5];
-		__le64	hostid;
-		__le64	rkey;
-	} regctl_ds[];
+	__u8	resv10[14];
+	struct nvme_registered_ctrl regctl_ds[];
+};
+
+struct nvme_registered_ctrl_ext {
+	__le16	cntlid;
+	__u8	rcsts;
+	__u8	rsvd3[5];
+	__le64	rkey;
+	__u8	hostid[16];
+	__u8	rsvd32[32];
+};
+
+struct nvme_reservation_status_ext {
+	__le32	gen;
+	__u8	rtype;
+	__u8	regctl[2];
+	__u8	resv5[2];
+	__u8	ptpls;
+	__u8	resv10[14];
+	__u8	rsvd24[40];
+	struct nvme_registered_ctrl_ext regctl_eds[];
 };
 
 enum nvme_async_event_type {
-- 
2.25.1


  parent reply	other threads:[~2023-04-07 20:06 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-07 20:05 [PATCH v6 00/18] Use block pr_ops in LIO Mike Christie
2023-04-07 20:05 ` [PATCH v6 01/18] block: Add PR callouts for read keys and reservation Mike Christie
2023-04-11  7:09   ` Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 02/18] block: Rename BLK_STS_NEXUS to BLK_STS_RESV_CONFLICT Mike Christie
2023-04-08  8:05   ` Chaitanya Kulkarni
2023-04-11  5:33   ` Christoph Hellwig
2023-04-11  7:09   ` Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 03/18] scsi: Rename sd_pr_command Mike Christie
2023-04-11  7:10   ` Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 04/18] scsi: Move sd_pr_type to scsi_common Mike Christie
2023-04-07 20:08   ` Bart Van Assche
2023-04-11  5:33   ` Christoph Hellwig
2023-04-11  7:11   ` Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 05/18] scsi: Add support for block PR read keys/reservation Mike Christie
2023-04-11  7:13   ` Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 06/18] dm: " Mike Christie
2023-04-11  7:13   ` Hannes Reinecke
2023-04-17 19:13   ` Mike Snitzer
2023-04-07 20:05 ` Mike Christie [this message]
2023-04-11  5:34   ` [PATCH v6 07/18] nvme: Fix reservation status related structs Christoph Hellwig
2023-04-11  7:15   ` Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 08/18] nvme: Don't hardcode the data len for pr commands Mike Christie
2023-04-11  7:15   ` Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 09/18] nvme: Move pr code to it's own file Mike Christie
2023-04-11  5:35   ` Christoph Hellwig
2023-04-11  7:17   ` Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 10/18] nvme: Add helper to send pr command Mike Christie
2023-04-08  8:07   ` Chaitanya Kulkarni
2023-04-11  7:18   ` Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 11/18] nvme: Add pr_ops read_keys support Mike Christie
2023-04-08  8:11   ` Chaitanya Kulkarni
2023-04-11  7:20   ` Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 12/18] nvme: Add a nvme_pr_type enum Mike Christie
2023-04-11  7:29   ` Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 13/18] nvme: Add pr_ops read_reservation support Mike Christie
2023-04-11  5:35   ` Christoph Hellwig
2023-04-11  7:30   ` Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 14/18] scsi: target: Rename sbc_ops to exec_cmd_ops Mike Christie
2023-04-11  7:30   ` Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 15/18] scsi: target: Allow backends to hook into PR handling Mike Christie
2023-04-11  7:31   ` Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 16/18] scsi: target: Pass struct target_opcode_descriptor to enabled Mike Christie
2023-04-11  5:36   ` Christoph Hellwig
2023-04-11  7:31   ` Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 17/18] scsi: target: Report and detect unsupported PR commands Mike Christie
2023-04-11  5:36   ` Christoph Hellwig
2023-04-11  7:32   ` Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 18/18] scsi: target: Add block PR support to iblock Mike Christie
2023-04-11  5:36   ` Christoph Hellwig
2023-04-11  7:33   ` Hannes Reinecke
2023-04-12  9:36 ` [PATCH v6 00/18] Use block pr_ops in LIO Naresh Kamboju
2023-04-12 10:25   ` Naresh Kamboju
2023-04-12 18:28     ` Mike Christie
2023-04-13  9:50       ` Naresh Kamboju
2023-04-12 10:57 ` Naresh Kamboju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230407200551.12660-8-michael.christie@oracle.com \
    --to=michael.christie@oracle.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=chaitanyak@nvidia.com \
    --cc=dm-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=snitzer@kernel.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox