Re: [PATCH v6 09/19] scsi: allow enabling and disabling command duration limits

Niklas Cassel
2023-04-11T08:17:23Z

On Tue, Apr 11, 2023 at 08:16:48AM +0200, Christoph Hellwig wrote:
> On Thu, Apr 06, 2023 at 01:32:38PM +0200, Niklas Cassel wrote:
> > + /*
> > + * For ATA devices, CDL needs to be enabled with a SET FEATURES command.
> > + */
> > + if (is_ata) {
>
> I don't think these hacks have any business in the SCSI layer. We should
> probbaly just do this unconditionally for CDL enabled ATA devices at
> probe time.

Hello Christoph,

While I agree that the pattern isn't especially beautiful,
the pattern is used in the SCSI layer already,
authored by none other than one of the SCSI maintainers themselves:
https://github.com/torvalds/linux/blame/v6.3-rc6/drivers/scsi/sd.c#L3066-L3074

I guess we could try to clean up all the occurrences of this pattern,
but considering that the pattern has existed in the SCSI layer for
10 years already, is it something that has to be addressed before this
series can be accepted?

Kind regards,
Niklas