From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
Avri Altman <avri.altman@wdc.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Asutosh Das <asutoshd@codeaurora.org>,
Tomas Henzl <thenzl@redhat.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Bart Van Assche <bvanassche@google.com>,
Bean Huo <beanhuo@micron.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Asutosh Das <quic_asutoshd@quicinc.com>
Subject: [PATCH v2 2/4] scsi: ufs: Simplify ufshcd_wl_shutdown()
Date: Mon, 17 Apr 2023 16:06:54 -0700 [thread overview]
Message-ID: <20230417230656.523826-3-bvanassche@acm.org> (raw)
In-Reply-To: <20230417230656.523826-1-bvanassche@acm.org>
Now that sd_shutdown() fails future I/O the code for quiescing LUNs in
ufshcd_wl_shutdown() is superfluous. Remove the code for quiescing LUNs.
Also remove the ufshcd_rpm_get_sync() call because it is not necessary
to resume a UFS device before submitting a START STOP UNIT command.
Cc: Asutosh Das <asutoshd@codeaurora.org>
Cc: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/ufs/core/ufshcd.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 9434328ba323..784787cf08c3 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -9768,22 +9768,12 @@ static int ufshcd_wl_resume(struct device *dev)
static void ufshcd_wl_shutdown(struct device *dev)
{
struct scsi_device *sdev = to_scsi_device(dev);
- struct ufs_hba *hba;
-
- hba = shost_priv(sdev->host);
+ struct ufs_hba *hba = shost_priv(sdev->host);
down(&hba->host_sem);
hba->shutting_down = true;
up(&hba->host_sem);
- /* Turn on everything while shutting down */
- ufshcd_rpm_get_sync(hba);
- scsi_device_quiesce(sdev);
- shost_for_each_device(sdev, hba->host) {
- if (sdev == hba->ufs_device_wlun)
- continue;
- scsi_device_quiesce(sdev);
- }
__ufshcd_wl_suspend(hba, UFS_SHUTDOWN_PM);
}
next prev parent reply other threads:[~2023-04-17 23:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 23:06 [PATCH v2 0/4] SCSI core and UFS patches for kernel v6.4 Bart Van Assche
2023-04-17 23:06 ` [PATCH v2 1/4] scsi: sd: Let sd_shutdown() fail future I/O Bart Van Assche
2023-04-18 4:37 ` Ming Lei
2023-04-18 14:09 ` Bart Van Assche
2023-04-18 5:06 ` Christoph Hellwig
2023-04-18 14:36 ` James Bottomley
2023-04-18 18:37 ` Bart Van Assche
2023-04-19 2:34 ` James Bottomley
2023-04-19 13:36 ` Tomas Henzl
2023-04-19 14:02 ` James Bottomley
2023-04-19 17:58 ` Bart Van Assche
2023-04-19 18:33 ` James Bottomley
2023-04-19 19:24 ` Bart Van Assche
2023-04-19 19:29 ` James Bottomley
2023-04-17 23:06 ` Bart Van Assche [this message]
2023-04-18 13:45 ` [PATCH v2 2/4] scsi: ufs: Simplify ufshcd_wl_shutdown() Adrian Hunter
2023-04-18 14:06 ` Bart Van Assche
2023-04-18 14:13 ` Adrian Hunter
2023-04-18 20:14 ` Bart Van Assche
2023-04-19 5:23 ` Adrian Hunter
2023-04-17 23:06 ` [PATCH v2 3/4] scsi: ufs: Increase the START STOP UNIT timeout from one to ten seconds Bart Van Assche
2023-04-18 7:30 ` Adrian Hunter
2023-04-18 7:57 ` Stanley Chu
2023-04-17 23:06 ` [PATCH v2 4/4] scsi: ufs: Fix handling of lrbp->cmd Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230417230656.523826-3-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=adrian.hunter@intel.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@google.com \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_asutoshd@quicinc.com \
--cc=stanley.chu@mediatek.com \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox