Re: [PATCH v2 1/3] scsi: libsas: Simplify sas_check_eeds()

Jason Yan
2023-04-21T01:55:15Z

On 2023/4/20 23:00, Christoph Hellwig wrote:
> On Thu, Apr 20, 2023 at 10:33:37PM +0800, Jason Yan wrote:
>> In sas_check_eeds() there is an empty branch. We can reverse the
>> test expression and then remove the empty branch. Also the the test
>> expression is a little bit complex so it deserves an individual
>> function. And make the continuing prototype lines indented after
>> the opening parenthesis to follow the standard coding style.
>>
>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
>> ---
>> drivers/scsi/libsas/sas_expander.c | 39 +++++++++++++++---------------
>> 1 file changed, 19 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c
>> index dc670304f181..70fd4f439664 100644
>> --- a/drivers/scsi/libsas/sas_expander.c
>> +++ b/drivers/scsi/libsas/sas_expander.c
>> @@ -1198,37 +1198,36 @@ static void sas_print_parent_topology_bug(struct domain_device *child,
>> sas_route_char(child, child_phy));
>> }
>>
>> +static bool sas_eeds_valid(struct domain_device *parent, struct domain_device *child)
>
> Please avoid the overly long line.

OK.