* [PATCH] ata: libata-scsi: fix ata_msense_control kdoc comment
@ 2023-05-23 7:47 Damien Le Moal
2023-05-23 9:17 ` Johannes Thumshirn
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Damien Le Moal @ 2023-05-23 7:47 UTC (permalink / raw)
To: linux-scsi, Martin K . Petersen
Add missing description of the spg argument of ata_msense_control().
Fixes: df60f9c64576 ("scsi: ata: libata: Add ATA feature control sub-page translation")
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
---
drivers/ata/libata-scsi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 69fc0d2c2123..40d6703e2d07 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -3850,6 +3850,7 @@ static unsigned int ata_mselect_control_ata_feature(struct ata_queued_cmd *qc,
/**
* ata_mselect_control - Simulate MODE SELECT for control page
* @qc: Storage for translated ATA taskfile
+ * @spg: target sub-page of the control page
* @buf: input buffer
* @len: number of valid bytes in the input buffer
* @fp: out parameter for the failed field on error
--
2.40.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ata: libata-scsi: fix ata_msense_control kdoc comment
2023-05-23 7:47 [PATCH] ata: libata-scsi: fix ata_msense_control kdoc comment Damien Le Moal
@ 2023-05-23 9:17 ` Johannes Thumshirn
2023-05-24 8:03 ` Niklas Cassel
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Johannes Thumshirn @ 2023-05-23 9:17 UTC (permalink / raw)
To: Damien Le Moal, linux-scsi@vger.kernel.org, Martin K . Petersen
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ata: libata-scsi: fix ata_msense_control kdoc comment
2023-05-23 7:47 [PATCH] ata: libata-scsi: fix ata_msense_control kdoc comment Damien Le Moal
2023-05-23 9:17 ` Johannes Thumshirn
@ 2023-05-24 8:03 ` Niklas Cassel
2023-05-31 15:21 ` Martin K. Petersen
2023-06-08 1:42 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Niklas Cassel @ 2023-05-24 8:03 UTC (permalink / raw)
To: Damien Le Moal; +Cc: linux-scsi@vger.kernel.org, Martin K . Petersen
On Tue, May 23, 2023 at 04:47:01PM +0900, Damien Le Moal wrote:
> Add missing description of the spg argument of ata_msense_control().
>
> Fixes: df60f9c64576 ("scsi: ata: libata: Add ATA feature control sub-page translation")
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> ---
> drivers/ata/libata-scsi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
> index 69fc0d2c2123..40d6703e2d07 100644
> --- a/drivers/ata/libata-scsi.c
> +++ b/drivers/ata/libata-scsi.c
> @@ -3850,6 +3850,7 @@ static unsigned int ata_mselect_control_ata_feature(struct ata_queued_cmd *qc,
> /**
> * ata_mselect_control - Simulate MODE SELECT for control page
> * @qc: Storage for translated ATA taskfile
> + * @spg: target sub-page of the control page
> * @buf: input buffer
> * @len: number of valid bytes in the input buffer
> * @fp: out parameter for the failed field on error
> --
> 2.40.1
>
Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ata: libata-scsi: fix ata_msense_control kdoc comment
2023-05-23 7:47 [PATCH] ata: libata-scsi: fix ata_msense_control kdoc comment Damien Le Moal
2023-05-23 9:17 ` Johannes Thumshirn
2023-05-24 8:03 ` Niklas Cassel
@ 2023-05-31 15:21 ` Martin K. Petersen
2023-06-08 1:42 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2023-05-31 15:21 UTC (permalink / raw)
To: Damien Le Moal; +Cc: linux-scsi, Martin K . Petersen
Damien,
> Add missing description of the spg argument of ata_msense_control().
Applied to 6.5/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ata: libata-scsi: fix ata_msense_control kdoc comment
2023-05-23 7:47 [PATCH] ata: libata-scsi: fix ata_msense_control kdoc comment Damien Le Moal
` (2 preceding siblings ...)
2023-05-31 15:21 ` Martin K. Petersen
@ 2023-06-08 1:42 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2023-06-08 1:42 UTC (permalink / raw)
To: linux-scsi, Damien Le Moal; +Cc: Martin K . Petersen
On Tue, 23 May 2023 16:47:01 +0900, Damien Le Moal wrote:
> Add missing description of the spg argument of ata_msense_control().
>
>
Applied to 6.5/scsi-queue, thanks!
[1/1] ata: libata-scsi: fix ata_msense_control kdoc comment
https://git.kernel.org/mkp/scsi/c/401f8ef3193f
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-08 1:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-23 7:47 [PATCH] ata: libata-scsi: fix ata_msense_control kdoc comment Damien Le Moal
2023-05-23 9:17 ` Johannes Thumshirn
2023-05-24 8:03 ` Niklas Cassel
2023-05-31 15:21 ` Martin K. Petersen
2023-06-08 1:42 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox