From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>
Subject: [PATCH v3 0/4] ufs: Do not requeue while ungating the clock
Date: Fri, 26 May 2023 10:29:45 -0700 [thread overview]
Message-ID: <20230526173007.1627017-1-bvanassche@acm.org> (raw)
Hi Martin,
In the traces we recorded while testing zoned storage we noticed that UFS
commands are requeued while the clock is being ungated. Command requeueing
makes it harder than necessary to preserve the command order. Hence this
patch series that modifies the SCSI core and also the UFS driver such that
clock ungating does not trigger command requeueing.
Please consider this patch series for the next merge window.
Thanks,
Bart.
Changes compared to v2:
- Only enable BLK_MQ_F_BLOCKING if necessary.
Changes compared to v1:
- Dropped patch "scsi: ufs: core: Unexport ufshcd_hold() and ufshcd_release()".
- Removed a ufshcd_scsi_block_requests() / ufshcd_scsi_unblock_requests() pair
from patch "scsi: ufs: Ungate the clock synchronously".
Bart Van Assche (4):
scsi: core: Rework scsi_host_block()
scsi: core: Support setting BLK_MQ_F_BLOCKING
scsi: ufs: Conditionally enable the BLK_MQ_F_BLOCKING flag
scsi: ufs: Ungate the clock synchronously
drivers/scsi/hosts.c | 1 +
drivers/scsi/scsi_lib.c | 26 +++++-----
drivers/ufs/core/ufs-sysfs.c | 2 +-
drivers/ufs/core/ufshcd-crypto.c | 2 +-
drivers/ufs/core/ufshcd-priv.h | 2 +-
drivers/ufs/core/ufshcd.c | 85 ++++++++++----------------------
include/scsi/scsi_host.h | 6 +++
include/ufs/ufshcd.h | 2 +-
8 files changed, 53 insertions(+), 73 deletions(-)
next reply other threads:[~2023-05-26 17:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 17:29 Bart Van Assche [this message]
2023-05-26 17:29 ` [PATCH v3 1/4] scsi: core: Rework scsi_host_block() Bart Van Assche
2023-05-26 17:29 ` [PATCH v3 2/4] scsi: core: Support setting BLK_MQ_F_BLOCKING Bart Van Assche
2023-05-26 17:29 ` [PATCH v3 3/4] scsi: ufs: Conditionally enable the BLK_MQ_F_BLOCKING flag Bart Van Assche
2023-05-29 6:51 ` Adrian Hunter
2023-05-26 17:29 ` [PATCH v3 4/4] scsi: ufs: Ungate the clock synchronously Bart Van Assche
2023-05-29 7:29 ` Adrian Hunter
2023-05-29 19:58 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230526173007.1627017-1-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=adrian.hunter@intel.com \
--cc=jaegeuk@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox