Re: [PATCH 05/31] cdrom: track if a cdrom_device_info was opened for data

Christoph Hellwig
2023-06-07T12:21:00Z

On Wed, Jun 07, 2023 at 02:13:33PM +0200, Hannes Reinecke wrote:
>> +++ b/include/linux/cdrom.h
>> @@ -64,6 +64,7 @@ struct cdrom_device_info {
>> int (*exit)(struct cdrom_device_info *);
>> int mrw_mode_page;
>> __s64 last_media_change_ms;
>> + bool opened_for_data;
>> };
>> struct cdrom_device_ops {
>
> Do we care about alignment here?
> integer followed by a 64 bit value followed by a bool seems
> like an automatic padding to me ...

I don't think the structure matter much here, but placing it before
last_media_change_ms still seems better. I'll change it.