Re: [PATCH 16/31] block: use the holder as indication for exclusive opens

Jinpu Wang
2023-06-07T09:40:21Z

On Tue, Jun 6, 2023 at 9:40 AM Christoph Hellwig <hch@lst.de> wrote:
>
> The current interface for exclusive opens is rather confusing as it
> requires both the FMODE_EXCL flag and a holder. Remove the need to pass
> FMODE_EXCL and just key off the exclusive open off a non-NULL holder.
>
> For blkdev_put this requires adding the holder argument, which provides
> better debug checking that only the holder actually releases the hold,
> but at the same time allows removing the now superfluous mode argument.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> block/bdev.c | 37 ++++++++++++++++------------
> block/fops.c | 6 +++--
> block/genhd.c | 5 ++--
> block/ioctl.c | 5 ++--
> drivers/block/drbd/drbd_nl.c | 23 ++++++++++-------
> drivers/block/pktcdvd.c | 13 +++++-----
> drivers/block/rnbd/rnbd-srv.c | 4 +--
Acked-by: Jack Wang <jinpu.wang@ionos.com> # for rnbd