Re: [PATCH 20/31] scsi: replace the fmode_t argument to scsi_ioctl with a simple bool

Hannes Reinecke
2023-06-07T13:05:01Z

On 6/6/23 09:39, Christoph Hellwig wrote:
> Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass
> a bool open_for_write to prepare for callers that won't have the fmode_t.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/scsi/ch.c | 3 ++-
> drivers/scsi/scsi_ioctl.c | 34 +++++++++++++++++-----------------
> drivers/scsi/sd.c | 2 +-
> drivers/scsi/sg.c | 5 +++--
> drivers/scsi/sr.c | 2 +-
> drivers/scsi/st.c | 2 +-
> include/scsi/scsi_ioctl.h | 2 +-
> 7 files changed, 26 insertions(+), 24 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes