From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70635C7EE23 for ; Thu, 8 Jun 2023 06:13:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234224AbjFHGNY (ORCPT ); Thu, 8 Jun 2023 02:13:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233943AbjFHGNX (ORCPT ); Thu, 8 Jun 2023 02:13:23 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A579CE57; Wed, 7 Jun 2023 23:13:22 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 1112A6732D; Thu, 8 Jun 2023 08:13:20 +0200 (CEST) Date: Thu, 8 Jun 2023 08:13:19 +0200 From: Christoph Hellwig To: Yu Kuai Cc: hch@lst.de, axboe@kernel.dk, dgilbert@interlog.com, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com Subject: Re: [PATCH v3 2/2] block: fix blktrace debugfs entries leakage Message-ID: <20230608061319.GB11927@lst.de> References: <20230608024159.1282953-1-yukuai1@huaweicloud.com> <20230608024159.1282953-3-yukuai1@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230608024159.1282953-3-yukuai1@huaweicloud.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Looks good (at least for now, I think the SG_IO support on /dev/sg really needs to go away or be completely separate from the disk one). Reviewed-by: Christoph Hellwig