Re: [PATCH v5 3/7] scsi: merge scsi_internal_device_block() and device_block()

Bart Van Assche
2023-06-12T18:00:27Z

On 6/12/23 09:50, mwilck@suse.com wrote:
> -static int scsi_internal_device_block(struct scsi_device *sdev)
> +static void scsi_device_block(struct scsi_device *sdev, void *data)
> {
> int err;
>
> @@ -2805,7 +2804,8 @@ static int scsi_internal_device_block(struct scsi_device *sdev)
> scsi_stop_queue(sdev, false);
> mutex_unlock(&sdev->state_mutex);
>
> - return err;
> + WARN_ONCE(err, "__scsi_internal_device_block_nowait(%s) failed: err = %d\n",
> + dev_name(&sdev->sdev_gendev), err);
> }

Hmm ... wasn't it your intention to change the reference to the
__scsi_internal_device_block_nowait() function in this message?

Thanks,

Bart.