From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB533EB64DC for ; Wed, 28 Jun 2023 20:10:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232066AbjF1UKS (ORCPT ); Wed, 28 Jun 2023 16:10:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231974AbjF1UJ5 (ORCPT ); Wed, 28 Jun 2023 16:09:57 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5817A1FE7 for ; Wed, 28 Jun 2023 13:09:55 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6686ef86110so114291b3a.2 for ; Wed, 28 Jun 2023 13:09:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1687982995; x=1690574995; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GgNPZYk/YIR/NjfHGUZee9n0grv7oBxdx9QypAqb0KM=; b=WfvYxnUL4Ty/eCmhlk8HZNMz6Ny82a3xTXLYv6oHkr21g+IazJSmxcWT1ghO8tJfPU 27kszKY5owbTLP6vSwyjzoiVEuxGnIp+cL4sldTr9XSD9Xk0MVC4cM8R5IgK+Bt5lPJ6 V3dArt47QlGzvaUGxlqrGu84O3Q2USAgm8NOU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687982995; x=1690574995; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GgNPZYk/YIR/NjfHGUZee9n0grv7oBxdx9QypAqb0KM=; b=Y9nih4TkIxJ8pr4eVypGYF9xlWvBv5QokzHZcrIjJKZmhVU1hu6heGn+uJzPfP2Bcf 56qGV+biqUoZVLbx9iU33ZpTVJ2dTqXok2dHPM3hcwOq8Jz27vbb8BgGpZ3DnTHEewg/ whiNQDrpF/Ew8Uc5mb6D+DdB3bP5mjqNC066Eq61//c1+3hvWFO/F8SrRGPkLJLy4fUh BRl9/pIcPsJv3O9o74D/e299NwKSBTde3qbAw0bSH5DV+HplOnrn7ZbG22w13ZPgDTR2 lwZptePHJNnSnk+pemGO7nfmijdG2GbS2BKlkNzNtbgWJTLvUYfdfm/NKEkCgBczGZ6A 21ZA== X-Gm-Message-State: AC+VfDzA0rlCIjCheZKwrXIrBGzEb9JdwjPDkWfjpAVdz6Adq8b/gq8V tiYfz0hBnUMOQ22aLbVIzJTsXg== X-Google-Smtp-Source: ACHHUZ75rKfbdZ3BSjLldKA1Me+qSORbVApKU+yaiv+WmANBo41nYloYPHc2r1IKD6tjn3/XJ+UldA== X-Received: by 2002:a05:6a00:139f:b0:676:4c90:ca60 with SMTP id t31-20020a056a00139f00b006764c90ca60mr9924148pfg.7.1687982994806; Wed, 28 Jun 2023 13:09:54 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id c23-20020a62e817000000b00678faa97189sm4869521pfi.112.2023.06.28.13.09.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 13:09:54 -0700 (PDT) Date: Wed, 28 Jun 2023 13:09:53 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: aacraid@microsemi.com, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 01/10][next] scsi: aacraid: Replace one-element array with flexible-array member Message-ID: <202306281309.C42CBC1CF@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Wed, Jun 28, 2023 at 11:54:27AM -0600, Gustavo A. R. Silva wrote: > Replace one-element array with flexible-array member in struct > aac_ciss_phys_luns_resp. I think the Subject was cut off (it lacks mention of aac_ciss_phys_luns_resp, where as the other patches mention the target struct). > This results in no differences in binary output. Confirmed. > > Issue found with the help of Coccinelle and audited and fixed, > manually. > > Link: https://github.com/KSPP/linux/issues/79 > Link: https://github.com/ClangBuiltLinux/linux/issues/1851 > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -- Kees Cook