From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62E68EB64DA for ; Wed, 28 Jun 2023 20:52:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231659AbjF1Uwz (ORCPT ); Wed, 28 Jun 2023 16:52:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231636AbjF1Uwu (ORCPT ); Wed, 28 Jun 2023 16:52:50 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 492CD1BCE for ; Wed, 28 Jun 2023 13:52:49 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-668709767b1so163977b3a.2 for ; Wed, 28 Jun 2023 13:52:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1687985569; x=1690577569; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hzojRQ1F0egJqRD59S+FcTqPfQzuWDtOgop6JLdMSGw=; b=HiZCgsxp983FQwUw2sx6AdlekN/G/snxYdNfXGidR0MDb7jLkQBBFNFwLrGSrQ8Glp fERHuElJlAG+HKiB7tDmZFk/hlwsXHeyhKiUZZa+VaBQhdTP1LUiOQJN4XErfGNoIihl oMBaNPGR0mKrDczhcQ9qXSMBEhdHf7Gy6/UQo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687985569; x=1690577569; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hzojRQ1F0egJqRD59S+FcTqPfQzuWDtOgop6JLdMSGw=; b=LFeH7zOlFojT4zjvMsDnyiqQ5IM1pRhNVo3FPvnjZ9AQD7P7yjROyyyTwUkEJQhz0p OoJu8NtfZvWueNE623FGqxJQm8fQ8iHzcIos8H5DKt1e61KHEW+lX59MFw7ZPIhghfn4 mQQwEbC+GFIIaPUzk7jsT+MhntodzaPO6CGlDKaRXfiiEBlOCt1w/OAZBwLbNkzUZ6YS OiXS2f1g5+vIww7FDgRIKQMXns4KdYl5T5KUbq8kNbgAE9hP7t02Q2dmhHTXVucqV9kS B20vh0LfqtVtKuji/P3JEgtzOWyFTTElPe+GFnMo8gRt/ByAF1z5zjt4eUNY112j9FvH BfMg== X-Gm-Message-State: AC+VfDyq10wehQFQeU10XRbMPmfLDTG9nLl6s5UR3dZdLMbsy2YSwkon 1fiEXVJEXBuCnLN+S+wU4ibDSQ== X-Google-Smtp-Source: ACHHUZ6aWKbpdlWdbqo0UZTOBgabSUelUcGn6RoJQGsfCDv2XWMn23NkmZOmuIik8ez8Eq2+BIMQaA== X-Received: by 2002:a05:6a00:2341:b0:680:98c:c58d with SMTP id j1-20020a056a00234100b00680098cc58dmr4879003pfj.2.1687985568796; Wed, 28 Jun 2023 13:52:48 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id d25-20020aa78159000000b0064378c52398sm7355134pfn.25.2023.06.28.13.52.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 13:52:48 -0700 (PDT) Date: Wed, 28 Jun 2023 13:52:47 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: aacraid@microsemi.com, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 06/10][next] scsi: aacraid: Use struct_size() helper in code related to struct sgmapraw Message-ID: <202306281352.815ED6569@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Wed, Jun 28, 2023 at 11:56:31AM -0600, Gustavo A. R. Silva wrote: > Prefer struct_size() over open-coded versions. Oh, I think you can add two more patches to convert sgmap and sgmap64 fibsize calculations too. -- Kees Cook