From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@kernel.org>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v2 3/5] block: nullblk: Set zone limits before revalidating zones
Date: Thu, 6 Jul 2023 14:41:14 +0200 [thread overview]
Message-ID: <20230706124114.GC12545@lst.de> (raw)
In-Reply-To: <20230630083935.433334-4-dlemoal@kernel.org>
On Fri, Jun 30, 2023 at 05:39:33PM +0900, Damien Le Moal wrote:
> + if (queue_is_mq(q))
> + return blk_revalidate_disk_zones(nullb->disk, NULL);
> +
> return 0;
I'd write this as:
if (!queue_is_mq(q)))
return 0;
return blk_revalidate_disk_zones(nullb->disk, NULL);
but that's just cosmetic. Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-07-06 12:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 8:39 [PATCH v2 0/5] Improve checks in blk_revalidate_disk_zones() Damien Le Moal
2023-06-30 8:39 ` [PATCH v2 1/5] scsi: sd_zbc: Set zone limits before revalidating zones Damien Le Moal
2023-07-06 12:39 ` Christoph Hellwig
2023-06-30 8:39 ` [PATCH v2 2/5] nvme: zns: " Damien Le Moal
2023-07-06 12:40 ` Christoph Hellwig
2023-06-30 8:39 ` [PATCH v2 3/5] block: nullblk: " Damien Le Moal
2023-07-06 12:41 ` Christoph Hellwig [this message]
2023-06-30 8:39 ` [PATCH v2 4/5] block: virtio_blk: " Damien Le Moal
2023-07-02 22:29 ` Dmitry Fomichev
2023-07-06 12:41 ` Christoph Hellwig
2023-06-30 8:39 ` [PATCH v2 5/5] block: improve checks in blk_revalidate_disk_zones() Damien Le Moal
2023-07-06 12:42 ` Christoph Hellwig
2023-06-30 23:21 ` [PATCH v2 0/5] Improve " Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706124114.GC12545@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).