From: Anastasia Kovaleva <a.kovaleva@yadro.com>
To: <martin.petersen@oracle.com>, <michael.christie@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <target-devel@vger.kernel.org>,
<linux@yadro.com>
Subject: [RFC PATCH 0/3] SCSI target logs
Date: Wed, 26 Jul 2023 14:55:06 +0300 [thread overview]
Message-ID: <20230726115509.357-1-a.kovaleva@yadro.com> (raw)
This patch is an initial work on scsi target logging improvement, that
was discussed here:
https://lore.kernel.org/target-devel/ZF0MiCRW8HWm8YYj@yadro.com/
This is an example of how it will look.
Things worth mentioning:
1. I've decided not to implement target_lun_LEVEL() and implement
target_cmd_LEVEL() instead because the mapped lun is stored in the
se_cmd structure, and most of the time we already have the cmd when
we want to log a lun.
2. Target prefix such as "core" or "iscsi" will be defined in the
beginning of each file.
For example, you can test it with such command:
sg_inq -f -c --page=255 /dev/sda
And the log output will look like that:
[ 2229.586394] target core (iqn.1996-04.de.suse:01:6e84cb30fc63 -> 1/0): INQUIRY with EVPD==0 but PAGE CODE=ff
For bio errors log will look like that:
[ 3354.495867] target iblock (iqn.1996-04.de.suse:01:6e84cb30fc63 -> 1/0): bio error: 0000000097ff0ac0, err: 10
I'll be thankful for your comments and suggestions. It would also be
great if you could tell me whether it would be better to send the entire
series for all modules at onse, or send patches for each module
individually as soon as they are ready.
Kind regards,
Anastasia Kovaleva
Anastasia Kovaleva (3):
target: core: Initial work on improving SCSI target logs
target: core: apply the new wrapper to spc
target: core: apply the new wrapper to iblock
drivers/target/target_core_iblock.c | 94 ++++++++++++++---------------
drivers/target/target_core_spc.c | 27 ++++-----
include/target/target_core_base.h | 25 ++++++++
3 files changed, 82 insertions(+), 64 deletions(-)
--
2.40.1
next reply other threads:[~2023-07-26 12:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 11:55 Anastasia Kovaleva [this message]
2023-07-26 11:55 ` [RFC PATCH 1/3] target: core: Initial work on improving SCSI target logs Anastasia Kovaleva
2023-07-26 11:55 ` [RFC PATCH 2/3] target: core: apply the new wrapper to spc Anastasia Kovaleva
2023-07-26 15:15 ` Bart Van Assche
2023-07-26 16:18 ` [DMARC Error]Re: " Konstantin Shelekhin
2023-07-26 11:55 ` [RFC PATCH 3/3] target: core: apply the new wrapper to iblock Anastasia Kovaleva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726115509.357-1-a.kovaleva@yadro.com \
--to=a.kovaleva@yadro.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox