public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* [jejb-scsi:misc 36/37] drivers/ufs/host/ufs-qcom.c:64:3: sparse: sparse: symbol 'ufs_qcom_bw_table' was not declared. Should it be static?
@ 2023-08-09  2:44 kernel test robot
  2023-08-09  6:11 ` Manivannan Sadhasivam
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2023-08-09  2:44 UTC (permalink / raw)
  To: Manivannan Sadhasivam; +Cc: oe-kbuild-all, linux-scsi, Martin K. Petersen

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc
head:   6cae9a3910ac1b5daf5ac3db9576b78cc4eff5aa
commit: 03ce80a1bb869f735de793f04c9c085b61884599 [36/37] scsi: ufs: qcom: Add support for scaling interconnects
config: arm64-randconfig-r071-20230808 (https://download.01.org/0day-ci/archive/20230809/202308091030.L5JrOBJB-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230809/202308091030.L5JrOBJB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308091030.L5JrOBJB-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/ufs/host/ufs-qcom.c:64:3: sparse: sparse: symbol 'ufs_qcom_bw_table' was not declared. Should it be static?

vim +/ufs_qcom_bw_table +64 drivers/ufs/host/ufs-qcom.c

    60	
    61	struct __ufs_qcom_bw_table {
    62		u32 mem_bw;
    63		u32 cfg_bw;
  > 64	} ufs_qcom_bw_table[MODE_MAX + 1][QCOM_UFS_MAX_GEAR + 1][QCOM_UFS_MAX_LANE + 1] = {
    65		[MODE_MIN][0][0]		   = { 0,		0 }, /* Bandwidth values in KB/s */
    66		[MODE_PWM][UFS_PWM_G1][UFS_LANE_1] = { 922,		1000 },
    67		[MODE_PWM][UFS_PWM_G2][UFS_LANE_1] = { 1844,		1000 },
    68		[MODE_PWM][UFS_PWM_G3][UFS_LANE_1] = { 3688,		1000 },
    69		[MODE_PWM][UFS_PWM_G4][UFS_LANE_1] = { 7376,		1000 },
    70		[MODE_PWM][UFS_PWM_G1][UFS_LANE_2] = { 1844,		1000 },
    71		[MODE_PWM][UFS_PWM_G2][UFS_LANE_2] = { 3688,		1000 },
    72		[MODE_PWM][UFS_PWM_G3][UFS_LANE_2] = { 7376,		1000 },
    73		[MODE_PWM][UFS_PWM_G4][UFS_LANE_2] = { 14752,		1000 },
    74		[MODE_HS_RA][UFS_HS_G1][UFS_LANE_1] = { 127796,		1000 },
    75		[MODE_HS_RA][UFS_HS_G2][UFS_LANE_1] = { 255591,		1000 },
    76		[MODE_HS_RA][UFS_HS_G3][UFS_LANE_1] = { 1492582,	102400 },
    77		[MODE_HS_RA][UFS_HS_G4][UFS_LANE_1] = { 2915200,	204800 },
    78		[MODE_HS_RA][UFS_HS_G1][UFS_LANE_2] = { 255591,		1000 },
    79		[MODE_HS_RA][UFS_HS_G2][UFS_LANE_2] = { 511181,		1000 },
    80		[MODE_HS_RA][UFS_HS_G3][UFS_LANE_2] = { 1492582,	204800 },
    81		[MODE_HS_RA][UFS_HS_G4][UFS_LANE_2] = { 2915200,	409600 },
    82		[MODE_HS_RB][UFS_HS_G1][UFS_LANE_1] = { 149422,		1000 },
    83		[MODE_HS_RB][UFS_HS_G2][UFS_LANE_1] = { 298189,		1000 },
    84		[MODE_HS_RB][UFS_HS_G3][UFS_LANE_1] = { 1492582,	102400 },
    85		[MODE_HS_RB][UFS_HS_G4][UFS_LANE_1] = { 2915200,	204800 },
    86		[MODE_HS_RB][UFS_HS_G1][UFS_LANE_2] = { 298189,		1000 },
    87		[MODE_HS_RB][UFS_HS_G2][UFS_LANE_2] = { 596378,		1000 },
    88		[MODE_HS_RB][UFS_HS_G3][UFS_LANE_2] = { 1492582,	204800 },
    89		[MODE_HS_RB][UFS_HS_G4][UFS_LANE_2] = { 2915200,	409600 },
    90		[MODE_MAX][0][0]		    = { 7643136,	307200 },
    91	};
    92	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [jejb-scsi:misc 36/37] drivers/ufs/host/ufs-qcom.c:64:3: sparse: sparse: symbol 'ufs_qcom_bw_table' was not declared. Should it be static?
  2023-08-09  2:44 [jejb-scsi:misc 36/37] drivers/ufs/host/ufs-qcom.c:64:3: sparse: sparse: symbol 'ufs_qcom_bw_table' was not declared. Should it be static? kernel test robot
@ 2023-08-09  6:11 ` Manivannan Sadhasivam
  0 siblings, 0 replies; 2+ messages in thread
From: Manivannan Sadhasivam @ 2023-08-09  6:11 UTC (permalink / raw)
  To: kernel test robot; +Cc: oe-kbuild-all, linux-scsi, Martin K. Petersen

On Wed, Aug 09, 2023 at 10:44:28AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc
> head:   6cae9a3910ac1b5daf5ac3db9576b78cc4eff5aa
> commit: 03ce80a1bb869f735de793f04c9c085b61884599 [36/37] scsi: ufs: qcom: Add support for scaling interconnects
> config: arm64-randconfig-r071-20230808 (https://download.01.org/0day-ci/archive/20230809/202308091030.L5JrOBJB-lkp@intel.com/config)
> compiler: aarch64-linux-gcc (GCC) 12.3.0
> reproduce: (https://download.01.org/0day-ci/archive/20230809/202308091030.L5JrOBJB-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202308091030.L5JrOBJB-lkp@intel.com/
> 
> sparse warnings: (new ones prefixed by >>)
> >> drivers/ufs/host/ufs-qcom.c:64:3: sparse: sparse: symbol 'ufs_qcom_bw_table' was not declared. Should it be static?
> 

This is already taken care by https://lore.kernel.org/all/20230802040154.10652-1-manivannan.sadhasivam@linaro.org/

- Mani

> vim +/ufs_qcom_bw_table +64 drivers/ufs/host/ufs-qcom.c
> 
>     60	
>     61	struct __ufs_qcom_bw_table {
>     62		u32 mem_bw;
>     63		u32 cfg_bw;
>   > 64	} ufs_qcom_bw_table[MODE_MAX + 1][QCOM_UFS_MAX_GEAR + 1][QCOM_UFS_MAX_LANE + 1] = {
>     65		[MODE_MIN][0][0]		   = { 0,		0 }, /* Bandwidth values in KB/s */
>     66		[MODE_PWM][UFS_PWM_G1][UFS_LANE_1] = { 922,		1000 },
>     67		[MODE_PWM][UFS_PWM_G2][UFS_LANE_1] = { 1844,		1000 },
>     68		[MODE_PWM][UFS_PWM_G3][UFS_LANE_1] = { 3688,		1000 },
>     69		[MODE_PWM][UFS_PWM_G4][UFS_LANE_1] = { 7376,		1000 },
>     70		[MODE_PWM][UFS_PWM_G1][UFS_LANE_2] = { 1844,		1000 },
>     71		[MODE_PWM][UFS_PWM_G2][UFS_LANE_2] = { 3688,		1000 },
>     72		[MODE_PWM][UFS_PWM_G3][UFS_LANE_2] = { 7376,		1000 },
>     73		[MODE_PWM][UFS_PWM_G4][UFS_LANE_2] = { 14752,		1000 },
>     74		[MODE_HS_RA][UFS_HS_G1][UFS_LANE_1] = { 127796,		1000 },
>     75		[MODE_HS_RA][UFS_HS_G2][UFS_LANE_1] = { 255591,		1000 },
>     76		[MODE_HS_RA][UFS_HS_G3][UFS_LANE_1] = { 1492582,	102400 },
>     77		[MODE_HS_RA][UFS_HS_G4][UFS_LANE_1] = { 2915200,	204800 },
>     78		[MODE_HS_RA][UFS_HS_G1][UFS_LANE_2] = { 255591,		1000 },
>     79		[MODE_HS_RA][UFS_HS_G2][UFS_LANE_2] = { 511181,		1000 },
>     80		[MODE_HS_RA][UFS_HS_G3][UFS_LANE_2] = { 1492582,	204800 },
>     81		[MODE_HS_RA][UFS_HS_G4][UFS_LANE_2] = { 2915200,	409600 },
>     82		[MODE_HS_RB][UFS_HS_G1][UFS_LANE_1] = { 149422,		1000 },
>     83		[MODE_HS_RB][UFS_HS_G2][UFS_LANE_1] = { 298189,		1000 },
>     84		[MODE_HS_RB][UFS_HS_G3][UFS_LANE_1] = { 1492582,	102400 },
>     85		[MODE_HS_RB][UFS_HS_G4][UFS_LANE_1] = { 2915200,	204800 },
>     86		[MODE_HS_RB][UFS_HS_G1][UFS_LANE_2] = { 298189,		1000 },
>     87		[MODE_HS_RB][UFS_HS_G2][UFS_LANE_2] = { 596378,		1000 },
>     88		[MODE_HS_RB][UFS_HS_G3][UFS_LANE_2] = { 1492582,	204800 },
>     89		[MODE_HS_RB][UFS_HS_G4][UFS_LANE_2] = { 2915200,	409600 },
>     90		[MODE_MAX][0][0]		    = { 7643136,	307200 },
>     91	};
>     92	
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

-- 
மணிவண்ணன் சதாசிவம்

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-09  6:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-09  2:44 [jejb-scsi:misc 36/37] drivers/ufs/host/ufs-qcom.c:64:3: sparse: sparse: symbol 'ufs_qcom_bw_table' was not declared. Should it be static? kernel test robot
2023-08-09  6:11 ` Manivannan Sadhasivam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox